Put object templates of the i18n extension on the heap object.

Put object templates of the i18n extension on the heap object.

Using function local statics doesn't work, as we need the templates per
isolate.

I'm not #ifdef'ing the definitions out, because kEmptyStringRootIndex
changes depending on whether the two additional slots are present or
not.

BUG=v8:2745
R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=15888

[Michael Starzinger, 2013-07-25 13:56:06]

LGTM with one comment.

https://codereview.chromium.org/20299002/diff/1/src/extensions/i18n/i18n-util...
File src/extensions/i18n/i18n-utils.cc (right):

https://codereview.chromium.org/20299002/diff/1/src/extensions/i18n/i18n-util...
src/extensions/i18n/i18n-utils.cc:156:
i::ObjectTemplateInfo::cast(internal->heap()->i18n_template_one()),
Just use internal->i18n_template_one() here, gives you an implicit handle.

https://codereview.chromium.org/20299002/diff/1/src/extensions/i18n/i18n-util...
src/extensions/i18n/i18n-utils.cc:174:
i::ObjectTemplateInfo::cast(internal->heap()->i18n_template_two()),
Likewise.

[Michael Starzinger, 2013-07-25 13:57:21]

https://codereview.chromium.org/20299002/diff/1/src/extensions/i18n/i18n-util...
File src/extensions/i18n/i18n-utils.cc (right):

https://codereview.chromium.org/20299002/diff/1/src/extensions/i18n/i18n-util...
src/extensions/i18n/i18n-utils.cc:156:
i::ObjectTemplateInfo::cast(internal->heap()->i18n_template_one()),
On 2013/07/25 13:56:06, Michael Starzinger wrote:
> Just use internal->i18n_template_one() here, gives you an implicit handle.

That should have been internal->factory()->i18n_template_one() here of course.

[jochen (gone - plz use gerrit), 2013-07-25 16:01:08]

Committed patchset #1 manually as r15888 (presubmit successful).