Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4424)

Unified Diff: chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h

Issue 2029863002: Refactor ChooserBubbleUiViewDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make ChooserContentView::ChooserControllerDestroying a private function Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h
diff --git a/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h b/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h
index af98369bcd019527aec27f7b922ea2d17887fc53..c809112bcc07a48871042a2dd0f4e0ffdcde1496 100644
--- a/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h
+++ b/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h
@@ -24,7 +24,7 @@ class ChooserBubbleUiViewDelegate;
// BubbleManager.
class ChooserBubbleUiView : public BubbleUi {
public:
- ChooserBubbleUiView(Browser* browser, ChooserController* controller);
+ ChooserBubbleUiView(Browser* browser, ChooserController* chooser_controller);
~ChooserBubbleUiView() override;
// BubbleUi:
@@ -37,8 +37,10 @@ class ChooserBubbleUiView : public BubbleUi {
views::View* GetAnchorView();
views::BubbleBorder::Arrow GetAnchorArrow();
- Browser* browser_; // Weak.
- ChooserController* controller_; // Weak.
+ Browser* browser_; // Weak.
+ // Weak, owned by ChooserBubbleDelegate.
+ ChooserController* chooser_controller_;
+ // Weak. Owned by its parent view.
ChooserBubbleUiViewDelegate* chooser_bubble_ui_view_delegate_;
DISALLOW_COPY_AND_ASSIGN(ChooserBubbleUiView);

Powered by Google App Engine
This is Rietveld 408576698