Refactor ChooserBubbleUiViewDelegate

chrome/browser/ui/views/chooser_content_view.cc

Index: chrome/browser/ui/views/chooser_content_view.cc
diff --git a/chrome/browser/ui/views/chooser_content_view.cc b/chrome/browser/ui/views/chooser_content_view.cc
new file mode 100644
index 0000000000000000000000000000000000000000..76f783156134199c1b3807f9b3ae7334092040cd
--- /dev/null
+++ b/chrome/browser/ui/views/chooser_content_view.cc
@@ -0,0 +1,207 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/chooser_content_view.h"
+
+#include <stddef.h>
+
+#include <algorithm>
+#include <vector>
+
+#include "base/macros.h"
+#include "base/strings/string16.h"
+#include "chrome/grit/generated_resources.h"
+#include "components/chooser_controller/chooser_controller.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "ui/gfx/range/range.h"
+#include "ui/views/controls/styled_label.h"
+#include "ui/views/controls/table/table_view.h"
+#include "ui/views/layout/grid_layout.h"
+#include "ui/views/window/dialog_client_view.h"
+
+namespace {
+
+// Chooser width

[msw, 2016/06/03 20:04:08]

nit: remove comment or add a trailing period; ditto below.

[juncai, 2016/06/07 18:11:05]

Done.

+const int kChooserWidth = 300;
+
+// Chooser height
+const int kChooserHeight = 200;
+
+}  // namespace
+
+class ChooserTableModel : public ui::TableModel,
+                          public ChooserController::Observer {
+ public:
+  explicit ChooserTableModel(ChooserController* chooser_controller);
+
+  // ui::TableModel:
+  int RowCount() override;
+  base::string16 GetText(int row, int column_id) override;
+  void SetObserver(ui::TableModelObserver* observer) override;
+
+  // ChooserController::Observer:
+  void OnOptionsInitialized() override;
+  void OnOptionAdded(size_t index) override;
+  void OnOptionRemoved(size_t index) override;
+
+  void Update();
+
+ private:
+  ui::TableModelObserver* observer_;
+  ChooserController* chooser_controller_;
+
+  DISALLOW_COPY_AND_ASSIGN(ChooserTableModel);
+};
+
+ChooserTableModel::ChooserTableModel(ChooserController* chooser_controller)
+    : observer_(nullptr), chooser_controller_(chooser_controller) {
+  chooser_controller_->set_observer(this);
+}
+
+int ChooserTableModel::RowCount() {
+  // When there are no devices, the table contains a message saying there
+  // are no devices, so the number of rows is always at least 1.
+  return std::max(static_cast<int>(chooser_controller_->NumOptions()), 1);
+}
+
+base::string16 ChooserTableModel::GetText(int row, int column_id) {
+  int num_options = static_cast<int>(chooser_controller_->NumOptions());
+  if (num_options == 0) {
+    DCHECK_EQ(0, row);
+    return l10n_util::GetStringUTF16(
+        IDS_CHOOSER_BUBBLE_NO_DEVICES_FOUND_PROMPT);
+  }
+
+  DCHECK_GE(row, 0);
+  DCHECK_LT(row, num_options);
+  return chooser_controller_->GetOption(static_cast<size_t>(row));
+}
+
+void ChooserTableModel::SetObserver(ui::TableModelObserver* observer) {
+  observer_ = observer;
+}
+
+void ChooserTableModel::OnOptionsInitialized() {
+  if (observer_) {
+    observer_->OnModelChanged();
+    Update();
+  }
+}
+
+void ChooserTableModel::OnOptionAdded(size_t index) {
+  if (observer_) {
+    observer_->OnItemsAdded(static_cast<int>(index), 1);
+    Update();
+  }
+}
+
+void ChooserTableModel::OnOptionRemoved(size_t index) {
+  if (observer_) {
+    observer_->OnItemsRemoved(static_cast<int>(index), 1);
+    Update();
+  }
+}
+
+void ChooserTableModel::Update() {
+  views::TableView* table_view = static_cast<views::TableView*>(observer_);
+
+  if (chooser_controller_->NumOptions() == 0) {
+    observer_->OnModelChanged();
+    table_view->SetEnabled(false);
+  } else {
+    table_view->SetEnabled(true);
+  }
+}
+
+ChooserContentView::ChooserContentView(views::View* anchor_view,
+                                       views::BubbleBorder::Arrow anchor_arrow,
+                                       ChooserController* chooser_controller)
+    : views::BubbleDialogDelegateView(anchor_view, anchor_arrow),
+      chooser_controller_(chooser_controller) {
+  // ------------------------------------
+  // | Chooser title                    |
+  // | -------------------------------- |
+  // | | option 0                     | |
+  // | | option 1                     | |
+  // | | option 2                     | |
+  // | |                              | |
+  // | |                              | |
+  // | |                              | |
+  // | -------------------------------- |
+  // |           [ Connect ] [ Cancel ] |
+  // |----------------------------------|
+  // | Not seeing your device? Get help |
+  // ------------------------------------
+
+  DCHECK(chooser_controller_);
+
+  views::GridLayout* layout = new views::GridLayout(this);
+  SetLayoutManager(layout);
+
+  views::ColumnSet* column_set = layout->AddColumnSet(0);
+  column_set->AddColumn(views::GridLayout::FILL, views::GridLayout::FILL, 1,
+                        views::GridLayout::USE_PREF, 0, 0);
+
+  // Lay out the table view.
+  layout->StartRow(0, 0);
+  std::vector<ui::TableColumn> table_columns;
+  table_columns.push_back(ui::TableColumn());
+  chooser_table_model_ = new ChooserTableModel(chooser_controller_);
+  table_view_ = new views::TableView(chooser_table_model_, table_columns,
+                                     views::TEXT_ONLY, true);
+  table_view_->set_select_on_remove(false);
+  chooser_table_model_->SetObserver(table_view_);
+  table_view_->SetObserver(this);
+  table_view_->SetEnabled(chooser_controller_->NumOptions() > 0);
+  layout->AddView(table_view_->CreateParentIfNecessary(), 1, 1,
+                  views::GridLayout::FILL, views::GridLayout::FILL,
+                  kChooserWidth, kChooserHeight);
+}
+
+ChooserContentView::~ChooserContentView() {
+  chooser_table_model_->SetObserver(nullptr);
+}
+
+bool ChooserContentView::ShouldShowWindowTitle() const {
+  return true;
+}
+
+base::string16 ChooserContentView::GetDialogButtonLabel(
+    ui::DialogButton button) const {
+  return l10n_util::GetStringUTF16(button == ui::DIALOG_BUTTON_OK
+                                       ? IDS_CHOOSER_BUBBLE_CONNECT_BUTTON_TEXT
+                                       : IDS_CHOOSER_BUBBLE_CANCEL_BUTTON_TEXT);
+}
+
+bool ChooserContentView::IsDialogButtonEnabled(ui::DialogButton button) const {
+  return button == ui::DIALOG_BUTTON_OK

[msw, 2016/06/03 20:04:08]

nit: button != ui::DIALOG_BUTTON_OK || !table_view_->selection_model().empty();

[juncai, 2016/06/07 18:11:05]

Done.

+             ? !table_view_->selection_model().empty()
+             : true;
+}
+
+views::View* ChooserContentView::CreateFootnoteView() {
+  base::string16 link =
+      l10n_util::GetStringUTF16(IDS_CHOOSER_BUBBLE_GET_HELP_LINK_TEXT);
+  size_t offset;

[msw, 2016/06/03 20:04:08]

nit: = 0

[juncai, 2016/06/07 18:11:05]

Done.

+  base::string16 text = l10n_util::GetStringFUTF16(
+      IDS_CHOOSER_BUBBLE_FOOTNOTE_TEXT, link, &offset);
+  views::StyledLabel* label = new views::StyledLabel(text, this);
+  label->AddStyleRange(gfx::Range(offset, offset + link.length()),
+                       views::StyledLabel::RangeStyleInfo::CreateForLink());
+  return label;
+}
+
+void ChooserContentView::StyledLabelLinkClicked(views::StyledLabel* label,
+                                                const gfx::Range& range,
+                                                int event_flags) {
+  chooser_controller_->OpenHelpCenterUrl();
+}
+
+void ChooserContentView::OnSelectionChanged() {
+  GetDialogClientView()->UpdateDialogButtons();
+}
+
+void ChooserContentView::ChooserControllerDestroying() {
+  chooser_controller_ = nullptr;

[msw, 2016/06/03 20:04:08]

Is this even necessary? Nothing checks for a null |chooser_controller_|.

[juncai, 2016/06/07 18:11:05]

This function is moved back to its original place at
|ChooserBubbleUiViewDelegate|.

+}