Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2029843002:
Stopped WebVR from being partially enabled during testing. (Closed)
DescriptionStopped WebVR from being partially enabled during testing.
Should prevent repeated instances of "blink::mojom::VRService not found" in test
logs.
BUG=614752
Committed: https://crrev.com/8f7b25a40b187d5214eafdc86190b811c247580a
Cr-Commit-Position: refs/heads/master@{#397335}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 17 (6 generated)
bajones@chromium.org changed reviewers: + esprehn@chromium.org
Removing the GeometryInterfaces dependencies is a not directly related to the bug. The the latest spec simply no longer requires it. I figured I'd take care of it while I was updating that line anyway.
The CQ bit was checked by bajones@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029843002/1
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by bajones@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029843002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Stopped WebVR from being partially enabled during testing. Should prevent repeated instances of "blink::mojom::VRService not found" in test logs. BUG=614752 ========== to ========== Stopped WebVR from being partially enabled during testing. Should prevent repeated instances of "blink::mojom::VRService not found" in test logs. BUG=614752 Committed: https://crrev.com/8f7b25a40b187d5214eafdc86190b811c247580a Cr-Commit-Position: refs/heads/master@{#397335} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8f7b25a40b187d5214eafdc86190b811c247580a Cr-Commit-Position: refs/heads/master@{#397335}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2030913002/ by vabr@chromium.org. The reason for reverting is: Speculative revert, may have broken FormAutofillTest.WebFormElementToFormDataTooManyFields on ASAN bots. For more info see: BUG=616730.
Message was sent while issue was closed.
rbyers@chromium.org changed reviewers: + rbyers@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/2029843002/diff/1/third_party/WebKit/Source/p... File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right): https://codereview.chromium.org/2029843002/diff/1/third_party/WebKit/Source/p... third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:226: WebVR status=experimental I don't think this change does what you think it did. You were trying to DISABLE WebVR during testing, right? status=experimental is strictly MORE enabled than status=test. See https://www.chromium.org/blink/runtime-enabled-features Perhaps you just want to remove the 'status' all together?
Message was sent while issue was closed.
On 2016/06/23 02:17:53, Rick Byers wrote: > https://codereview.chromium.org/2029843002/diff/1/third_party/WebKit/Source/p... > File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right): > > https://codereview.chromium.org/2029843002/diff/1/third_party/WebKit/Source/p... > third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:226: WebVR > status=experimental > I don't think this change does what you think it did. You were trying to > DISABLE WebVR during testing, right? status=experimental is strictly MORE > enabled than status=test. See > https://www.chromium.org/blink/runtime-enabled-features > > Perhaps you just want to remove the 'status' all together? You're correct that I misunderstood the status, but it's already been removed as you suggested in https://codereview.chromium.org/2055943002, which was about two weeks ago. You're still seeing the message in the logs?
Message was sent while issue was closed.
On 2016/06/23 03:30:13, bajones wrote: > On 2016/06/23 02:17:53, Rick Byers wrote: > > > https://codereview.chromium.org/2029843002/diff/1/third_party/WebKit/Source/p... > > File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right): > > > > > https://codereview.chromium.org/2029843002/diff/1/third_party/WebKit/Source/p... > > third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:226: WebVR > > status=experimental > > I don't think this change does what you think it did. You were trying to > > DISABLE WebVR during testing, right? status=experimental is strictly MORE > > enabled than status=test. See > > https://www.chromium.org/blink/runtime-enabled-features > > > > Perhaps you just want to remove the 'status' all together? > > You're correct that I misunderstood the status, but it's already been removed as > you suggested in https://codereview.chromium.org/2055943002, which was about two > weeks ago. You're still seeing the message in the logs? Yep, I see it every time I run "content_shell --run-layout-test" and in all the tryjob error logs, eg: https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
