add --writeChecksumBasedFilenames flag to render_pictures

debugger/QT/SkDebuggerGUI.cpp

Index: debugger/QT/SkDebuggerGUI.cpp
diff --git a/debugger/QT/SkDebuggerGUI.cpp b/debugger/QT/SkDebuggerGUI.cpp
index b777aa1cfa8bdfe70e31c6750b882ab9f6cdec13..a4afc419bb97782e22c41a952e04b405f4ec0d2a 100644
--- a/debugger/QT/SkDebuggerGUI.cpp
+++ b/debugger/QT/SkDebuggerGUI.cpp
@@ -319,10 +319,10 @@ void SkDebuggerGUI::run(SkTimedPicture* pict,
         return;
     }
 

[robertphillips1, 2014/03/19 14:44:15]

This seems a bit odd. We usually signal optional behavior by having a pointer
parameter and passing NULL.

[epoger, 2014/03/19 15:20:29]

Agreed.  I think this means 1 or 2 changes, what do you think?

1. Change init() to take const SkString* (or perhaps const char*), and copy the
strings passed in

2. Change fOutputDir and fInputFilename to be SkString* (or perhaps const
char*).  Or should they stay as SkString, so we don't need to worry about
allocating/deallocating memory to hold the SkString object during the
PictureRenderer object's lifetime?

[robertphillips, 2014/03/19 16:06:50]

I think changing the parameters to be pointers but keeping the internal class
members as SkStrings would be best. This would match our API style but minimize
the allocation/deallocation concerns.

[epoger, 2014/03/19 16:48:26]

Done.

-    renderer->init(pict);
+    renderer->init(pict, SkString(), SkString(), false);
 
     renderer->setup();
-    renderer->render(NULL);
+    renderer->render();
     renderer->resetState(true);    // flush, swapBuffers and Finish
 
     // We throw this away the first batch of times to remove first time effects (such as paging in this program)
@@ -330,7 +330,7 @@ void SkDebuggerGUI::run(SkTimedPicture* pict,
 
     for (int i = 0; i < repeats; ++i) {
         renderer->setup();
-        renderer->render(NULL);
+        renderer->render();
         renderer->resetState(false);  // flush & swapBuffers, but don't Finish
     }
     renderer->resetState(true);    // flush, swapBuffers and Finish