third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py - Issue 2029823002: Fix MockFileSystem.walk and add test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py

Issue 2029823002: Fix MockFileSystem.walk and add test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: set dry_run to False Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py

index 6b6e7c9f422f91384cdd33c5fac50ab0387471e3..44c7d8043d507f9dad2c683232b2e28ea01e5dd7 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py

@@ -223,7 +223,12 @@ class MockFileSystem(object):

dirs.append(dir)

else:

files.append(remaining)

- return [(top[:-1], dirs, files)]

+ file_system_tuples = [(top[:-1], dirs, files)]

+ for dir in dirs:

+ dir = top + dir

+ tuples_from_subdirs = self.walk(dir)

+ file_system_tuples += tuples_from_subdirs

+ return file_system_tuples

def mtime(self, path):

if self.exists(path):

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock_unittest.py » ('j') | no next file with comments »