Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: cc/quads/shared_quad_state.cc

Issue 2029813002: cc::SharedQuadState: drop CopyFrom and add copy constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed unit test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/quads/shared_quad_state.h ('k') | cc/surfaces/surface_aggregator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/quads/shared_quad_state.cc
diff --git a/cc/quads/shared_quad_state.cc b/cc/quads/shared_quad_state.cc
index aa630c52f3959dc80b6e6f491ed2c6d6919386e8..9afdfd4d54ebe678b631ffa31a4b8817d9092159 100644
--- a/cc/quads/shared_quad_state.cc
+++ b/cc/quads/shared_quad_state.cc
@@ -19,16 +19,22 @@ SharedQuadState::SharedQuadState()
sorting_context_id(0) {
}
+SharedQuadState::SharedQuadState(const SharedQuadState& other)
danakj 2016/06/01 22:37:46 use = default
Fady Samuel 2016/06/01 22:44:12 Done.
+ : quad_to_target_transform(other.quad_to_target_transform),
+ quad_layer_bounds(other.quad_layer_bounds),
+ visible_quad_layer_rect(other.visible_quad_layer_rect),
+ clip_rect(other.clip_rect),
+ is_clipped(other.is_clipped),
+ opacity(other.opacity),
+ blend_mode(other.blend_mode),
+ sorting_context_id(other.sorting_context_id) {}
+
SharedQuadState::~SharedQuadState() {
TRACE_EVENT_OBJECT_DELETED_WITH_ID(
TRACE_DISABLED_BY_DEFAULT("cc.debug.quads"),
"cc::SharedQuadState", this);
}
-void SharedQuadState::CopyFrom(const SharedQuadState* other) {
- *this = *other;
-}
-
void SharedQuadState::SetAll(const gfx::Transform& quad_to_target_transform,
const gfx::Size& quad_layer_bounds,
const gfx::Rect& visible_quad_layer_rect,
« no previous file with comments | « cc/quads/shared_quad_state.h ('k') | cc/surfaces/surface_aggregator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698