url_canon_icu.cc - Issue 2029803003: Update to Chromium //url at Chromium commit 79dc59ac7602413181079ecb463873e29a1d7d0a.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: url_canon_icu.cc

Issue 2029803003: Update to Chromium //url at Chromium commit 79dc59ac7602413181079ecb463873e29a1d7d0a. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/domokit/gurl@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: url_canon_icu.cc

diff --git a/url_canon_icu.cc b/url_canon_icu.cc

index 741bed22abf09f0e9b1eb778f67fc3ae155a5ee5..8a80d7109d9cc925090ee247ef17253eb53136bb 100644

--- a/url_canon_icu.cc

+++ b/url_canon_icu.cc

@@ -99,8 +99,10 @@ struct UIDNAWrapper {

// TODO(jungshik): Change options as different parties (browsers,

// registrars, search engines) converge toward a consensus.

value = uidna_openUTS46(UIDNA_CHECK_BIDI, &err);

- if (U_FAILURE(err))

+ if (U_FAILURE(err)) {

+ CHECK(false) << "failed to open UTS46 data with error: " << err;

value = NULL;

+ }

}

UIDNA* value;

« no previous file with comments | « url_canon_host.cc ('k') | url_canon_internal.h » ('j') | no next file with comments »