Add an entry in histograms.xml for SafeBrowsing.V4UpdateHttpResponseOrErrorCode

Add a histogram for tracking the response codes and error codes when trying the fetch hash-prefix updates from the Pver4 SafeBrowsing service.

BUG=543161, 616603
Committed: https://crrev.com/d691f496520357a0a39769c162932ae0ac48fa2a
Cr-Commit-Position: refs/heads/master@{#398160}

[vakh (use Gerrit instead), 2016-06-01 20:37:57]

vakh@chromium.org changed reviewers:
+ nparker@chromium.org

[vakh (use Gerrit instead), 2016-06-01 21:38:59]

Description was changed from

==========
Add a histogram to track the network error cases for V4UpdateProtocolManager.

BUG=543161
==========

to

==========
Add a histogram to track the network error cases for V4UpdateProtocolManager.

BUG=543161, 616603
==========

[Steven Holte, 2016-06-02 20:53:42]

holte@chromium.org changed reviewers:
+ holte@chromium.org

[Steven Holte, 2016-06-02 20:53:43]

lgtm

[Nathan Parker, 2016-06-02 20:56:31]

https://codereview.chromium.org/2029753002/diff/1/components/safe_browsing_db...
File components/safe_browsing_db/v4_update_protocol_manager.cc (right):

https://codereview.chromium.org/2029753002/diff/1/components/safe_browsing_db...
components/safe_browsing_db/v4_update_protocol_manager.cc:334:
UMA_HISTOGRAM_SPARSE_SLOWLY("SafeBrowsing.V4UpdateNetworkError",
How about recording both the network error or status, like
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/saf...

[vakh (use Gerrit instead), 2016-06-02 21:38:13]

Just add an entry in histograms.xml for
SafeBrowsing.V4UpdateHttpResponseOrErrorCode. Remove
SafeBrowsing.V4UpdateNetworkError

[vakh (use Gerrit instead), 2016-06-02 21:41:06]

Remove #include 'sparse_histogram.h'

[vakh (use Gerrit instead), 2016-06-02 21:43:11]

Description was changed from

==========
Add a histogram to track the network error cases for V4UpdateProtocolManager.

BUG=543161, 616603
==========

to

==========
Add a histogram for tracking the response codes and error codes when trying the
fetch hash-prefix updates from the Pver4 SafeBrowsing service.

BUG=543161, 616603
==========

[vakh (use Gerrit instead), 2016-06-02 21:43:27]

https://codereview.chromium.org/2029753002/diff/1/components/safe_browsing_db...
File components/safe_browsing_db/v4_update_protocol_manager.cc (right):

https://codereview.chromium.org/2029753002/diff/1/components/safe_browsing_db...
components/safe_browsing_db/v4_update_protocol_manager.cc:334:
UMA_HISTOGRAM_SPARSE_SLOWLY("SafeBrowsing.V4UpdateNetworkError",
On 2016/06/02 20:56:31, Nathan Parker wrote:
> How about recording both the network error or status, like
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/saf...

Done.

[Nathan Parker, 2016-06-06 20:19:17]

lgtm

[vakh (use Gerrit instead), 2016-06-06 20:22:05]

The CQ bit was checked by vakh@chromium.org

[vakh (use Gerrit instead), 2016-06-06 20:22:06]

The patchset sent to the CQ was uploaded after l-g-t-m from holte@chromium.org
Link to the patchset: https://codereview.chromium.org/2029753002/#ps40001
(title: "Remove #include 'sparse_histogram.h'")

[commit-bot: I haz the power, 2016-06-06 20:22:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2029753002/40001

[commit-bot: I haz the power, 2016-06-06 21:34:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 21:34:08]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[vakh (use Gerrit instead), 2016-06-06 21:38:48]

git fetch && git pull && gclient sync

[vakh (use Gerrit instead), 2016-06-06 21:39:18]

The CQ bit was checked by vakh@chromium.org

[vakh (use Gerrit instead), 2016-06-06 21:39:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
nparker@chromium.org, holte@chromium.org
Link to the patchset: https://codereview.chromium.org/2029753002/#ps60001
(title: "git fetch && git pull && gclient sync")

[commit-bot: I haz the power, 2016-06-06 21:39:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2029753002/60001

[commit-bot: I haz the power, 2016-06-07 00:09:43]

Description was changed from

==========
Add a histogram for tracking the response codes and error codes when trying the
fetch hash-prefix updates from the Pver4 SafeBrowsing service.

BUG=543161, 616603
==========

to

==========
Add a histogram for tracking the response codes and error codes when trying the
fetch hash-prefix updates from the Pver4 SafeBrowsing service.

BUG=543161, 616603
==========

[commit-bot: I haz the power, 2016-06-07 00:09:47]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-07 00:10:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-07 00:11:43]

Description was changed from

==========
Add a histogram for tracking the response codes and error codes when trying the
fetch hash-prefix updates from the Pver4 SafeBrowsing service.

BUG=543161, 616603
==========

to

==========
Add a histogram for tracking the response codes and error codes when trying the
fetch hash-prefix updates from the Pver4 SafeBrowsing service.

BUG=543161, 616603

Committed: https://crrev.com/d691f496520357a0a39769c162932ae0ac48fa2a
Cr-Commit-Position: refs/heads/master@{#398160}
==========

[commit-bot: I haz the power, 2016-06-07 00:11:44]

Patchset 4 (id:??) landed as
https://crrev.com/d691f496520357a0a39769c162932ae0ac48fa2a
Cr-Commit-Position: refs/heads/master@{#398160}