components/mus/public/cpp/tests/test_window_tree_client_setup.cc - Issue 2029743002: Check WindowTreeClient for empty inflight queue upon teardown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/mus/public/cpp/tests/test_window_tree_client_setup.cc

Issue 2029743002: Check WindowTreeClient for empty inflight queue upon teardown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/mus/public/cpp/lib/window_tree_client.cc ('k') | components/mus/public/cpp/tests/window_tree_client_private.h » ('j') | components/mus/public/cpp/tests/window_tree_client_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/mus/public/cpp/tests/test_window_tree_client_setup.cc

diff --git a/components/mus/public/cpp/tests/test_window_tree_client_setup.cc b/components/mus/public/cpp/tests/test_window_tree_client_setup.cc

index 7a2e938313512abfddd90777d7710bf2741172f7..73431e6a14706049d91a3dffe7a5d437dde31ed8 100644

--- a/components/mus/public/cpp/tests/test_window_tree_client_setup.cc

+++ b/components/mus/public/cpp/tests/test_window_tree_client_setup.cc

@@ -37,6 +37,9 @@ WindowTreeClient* TestWindowTreeClientSetup::window_tree_client() {

void TestWindowTreeClientSetup::OnWillDestroyClient(

mus::WindowTreeClient* client) {

+ // |window_tree_| stubs out the connection to the Mus Window Server. So we

+ // need to clear the client queue before tear down.

+ WindowTreeClientPrivate(window_tree_client_.get()).ClearInFlightQueue();

// See comment in header as to why we do this.

window_tree_client_.release();

}