Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: components/mus/public/cpp/lib/window_tree_client.cc

Issue 2029743002: Check WindowTreeClient for empty inflight queue upon teardown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/mus/public/cpp/window_tree_client.h" 5 #include "components/mus/public/cpp/window_tree_client.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 // exception is the window manager and embed roots, which may know about 124 // exception is the window manager and embed roots, which may know about
125 // other random windows that it doesn't own. 125 // other random windows that it doesn't own.
126 // NOTE: we manually delete as we're a friend. 126 // NOTE: we manually delete as we're a friend.
127 while (!tracker.windows().empty()) 127 while (!tracker.windows().empty())
128 delete tracker.windows().front(); 128 delete tracker.windows().front();
129 129
130 FOR_EACH_OBSERVER(WindowTreeClientObserver, observers_, 130 FOR_EACH_OBSERVER(WindowTreeClientObserver, observers_,
131 OnWillDestroyClient(this)); 131 OnWillDestroyClient(this));
132 132
133 delegate_->OnWindowTreeClientDestroyed(this); 133 delegate_->OnWindowTreeClientDestroyed(this);
134
135 DCHECK(in_flight_map_.empty());
134 } 136 }
135 137
136 void WindowTreeClient::ConnectViaWindowTreeFactory( 138 void WindowTreeClient::ConnectViaWindowTreeFactory(
137 shell::Connector* connector) { 139 shell::Connector* connector) {
138 // Clients created with no root shouldn't delete automatically. 140 // Clients created with no root shouldn't delete automatically.
139 delete_on_no_roots_ = false; 141 delete_on_no_roots_ = false;
140 142
141 // The client id doesn't really matter, we use 101 purely for debugging. 143 // The client id doesn't really matter, we use 101 purely for debugging.
142 client_id_ = 101; 144 client_id_ = 101;
143 145
(...skipping 958 matching lines...) Expand 10 before | Expand all | Expand 10 after
1102 Window* window, 1104 Window* window,
1103 const gfx::Vector2d& offset, 1105 const gfx::Vector2d& offset,
1104 const gfx::Insets& hit_area) { 1106 const gfx::Insets& hit_area) {
1105 if (window_manager_internal_client_) { 1107 if (window_manager_internal_client_) {
1106 window_manager_internal_client_->SetUnderlaySurfaceOffsetAndExtendedHitArea( 1108 window_manager_internal_client_->SetUnderlaySurfaceOffsetAndExtendedHitArea(
1107 server_id(window), offset.x(), offset.y(), hit_area); 1109 server_id(window), offset.x(), offset.y(), hit_area);
1108 } 1110 }
1109 } 1111 }
1110 1112
1111 } // namespace mus 1113 } // namespace mus
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698