Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2029733003: Views: Replace resource ids with ui::TextEditCommand enum for text editing commands in Textfield. (Closed)

Created:
4 years, 6 months ago by karandeepb
Modified:
4 years, 6 months ago
Reviewers:
tapted
CC:
chromium-reviews, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, sievers+watch_chromium.org, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, jam, jbauman+watch_chromium.org, nona+watch_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, darin-cc_chromium.org, lethalantidote+watch-blimp_chromium.org, kalyank, dtrainor+watch-blimp_chromium.org, tdresser+watch_chromium.org, piman+watch_chromium.org, khushalsagar+watch-blimp_chromium.org, elijahtaylor+arcwatch_chromium.org, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, tfarina, shuchen+watch_chromium.org, lhchavez+watch_chromium.org, danakj+watch_chromium.org, James Su, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Constituent CLs- 1. http://crrev.com/2031433002: Views::Textfield: Decouple handling of menu and text editing commands. 2. http://crrev.com/2027133002: Modify ui::TextInputClient to use ui::TextEditCommand enum in place of resource ids. 3. http://crrev.com/2031913002: Remove ui::TextEditCommand::DELETE_SELECTION. 4. http://crrev.com/2030813002: Correct typo in ui::TextEditCommandAuraLinux. 5. http://crrev.com/2064053002: Move ui/events/linux/* to ui/base/ime/linux/. 6. http://crrev.com/2034623002: Unify ui::TextEditCommand and ui::TextEditCommandAuraLinux::CommandId..

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Fix compile #

Patch Set 5 : === #

Patch Set 6 : === #

Unified diffs Side-by-side diffs Delta from patch set Stats (+999 lines, -973 lines) Patch
M chrome/browser/ui/browser_command_controller.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_key_bindings_handler.h View 1 2 3 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_key_bindings_handler.cc View 1 2 3 9 chunks +115 lines, -81 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 2 3 4 5 6 chunks +51 lines, -15 lines 0 comments Download
M components/arc/ime/arc_ime_service.h View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
M components/arc/ime/arc_ime_service.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 4 5 2 chunks +6 lines, -5 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 2 1 chunk +74 lines, -74 lines 0 comments Download
M ui/base/ime/BUILD.gn View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
M ui/base/ime/dummy_text_input_client.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/dummy_text_input_client.cc View 1 2 3 4 5 1 chunk +4 lines, -3 lines 0 comments Download
A ui/base/ime/linux/text_edit_command_auralinux.h View 1 2 3 4 1 chunk +38 lines, -0 lines 0 comments Download
A ui/base/ime/linux/text_edit_command_auralinux.cc View 1 2 3 1 chunk +130 lines, -0 lines 0 comments Download
A + ui/base/ime/linux/text_edit_key_bindings_delegate_auralinux.h View 1 2 3 3 chunks +8 lines, -8 lines 0 comments Download
A + ui/base/ime/linux/text_edit_key_bindings_delegate_auralinux.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A ui/base/ime/text_edit_commands.h View 1 2 3 1 chunk +70 lines, -0 lines 0 comments Download
M ui/base/ime/text_input_client.h View 1 2 3 4 5 2 chunks +9 lines, -8 lines 0 comments Download
M ui/base/ime/ui_base_ime.gyp View 1 2 3 2 chunks +11 lines, -0 lines 0 comments Download
M ui/events/BUILD.gn View 1 2 3 1 chunk +0 lines, -9 lines 0 comments Download
M ui/events/events.gyp View 1 2 3 2 chunks +0 lines, -12 lines 0 comments Download
M ui/events/linux/text_edit_command_auralinux.h View 1 2 3 1 chunk +0 lines, -82 lines 0 comments Download
M ui/events/linux/text_edit_command_auralinux.cc View 1 2 3 1 chunk +0 lines, -124 lines 0 comments Download
D ui/events/linux/text_edit_key_bindings_delegate_auralinux.h View 1 2 3 1 chunk +0 lines, -43 lines 0 comments Download
D ui/events/linux/text_edit_key_bindings_delegate_auralinux.cc View 1 2 3 1 chunk +0 lines, -23 lines 0 comments Download
M ui/strings/ui_strings.grd View 1 chunk +0 lines, -66 lines 0 comments Download
M ui/views/cocoa/bridged_content_view.mm View 1 2 3 4 5 15 chunks +88 lines, -72 lines 0 comments Download
M ui/views/controls/prefix_selector.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/prefix_selector.cc View 1 2 3 4 5 1 chunk +4 lines, -3 lines 0 comments Download
M ui/views/controls/textfield/textfield.h View 1 2 3 4 5 4 chunks +11 lines, -10 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 2 3 4 5 17 chunks +338 lines, -306 lines 0 comments Download
M ui/views/controls/textfield/textfield_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/views/linux_ui/linux_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view_unittest.cc View 1 2 3 3 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (9 generated)
karandeepb
4 years, 6 months ago (2016-06-06 06:58:44 UTC) #4 
PTAL Trent. Have split up this CL into several smaller CLs (see CL description)
for ease of review. Except Patch 3 and 7, most of the patches are fairly
trivial. 

Patch 7 still needs some cleanup, holding it currently, for ease of review.

Also, still have to modify BridgedContentView to use all the newly added
commands.

Powered by Google App Engine
This is Rietveld 408576698