Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: pkg/dartino_compiler/lib/vm_context.dart

Issue 2029723004: Don't quit debugger when the program terminates, only after `quit`. Base URL: git@github.com:dartino/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dartino_compiler/lib/src/worker/developer.dart ('k') | tests/cli_tests/interactive_debugger_tests.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dartino_compiler/lib/vm_context.dart
diff --git a/pkg/dartino_compiler/lib/vm_context.dart b/pkg/dartino_compiler/lib/vm_context.dart
index b6ba4c5844dfb51be15649279fdd99639d3dd5b1..fb9ef7c7629a04eb8603e0e61715b8c2daf6c246 100644
--- a/pkg/dartino_compiler/lib/vm_context.dart
+++ b/pkg/dartino_compiler/lib/vm_context.dart
@@ -475,8 +475,7 @@ class DartinoVmContext {
interactiveExitCode = 0;
running = false;
loaded = false;
- // TODO(ahe): Let the caller terminate the session. See issue 67.
- await terminate();
+ terminated = true;
break;
case VmCommandCode.ConnectionError:
« no previous file with comments | « pkg/dartino_compiler/lib/src/worker/developer.dart ('k') | tests/cli_tests/interactive_debugger_tests.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698