Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2029723004: Don't quit debugger when the program terminates, only after `quit`.

Created:
4 years, 6 months ago by sigurdm
Modified:
4 years, 6 months ago
Reviewers:
CC:
dartino-code-reviews_googlegroups.com
Base URL:
git@github.com:dartino/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't quit debugger when the program terminates, only after `quit`. Also fixes the remaining part of issue #67 by not terminating the vm connection immediately after receiving a ProcessTerminate.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -27 lines) Patch
M pkg/dartino_compiler/lib/cli_debugger.dart View 5 chunks +12 lines, -7 lines 0 comments Download
M pkg/dartino_compiler/lib/src/worker/developer.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/dartino_compiler/lib/vm_context.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/cli_tests/interactive_debugger_tests.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/dartino_compiler/incremental/dartino_vm_tester.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/dartino_compiler/incremental/incremental_test_runner.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/debugger/accessors_expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/debugger/async_expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M tests/debugger/async_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/debugger/break_after_spawn_expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M tests/debugger/break_after_spawn_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/debugger/break_in_anonymous_function_expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M tests/debugger/break_in_anonymous_function_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/debugger/break_in_loop_expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M tests/debugger/break_in_other_process_expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M tests/debugger/break_in_other_process_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/debugger/break_line_pattern_expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M tests/debugger/break_line_pattern_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/debugger/constructor_expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/debugger/debugger_tests.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/debugger/empty_column_expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M tests/debugger/empty_column_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/debugger/empty_expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/debugger/empty_variable_declaration_expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/debugger/fibers_expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M tests/debugger/fibers_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/debugger/find_file_expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M tests/debugger/find_file_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/debugger/finish_expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M tests/debugger/finish_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/debugger/frame_restart_expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M tests/debugger/frame_restart_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/debugger/is_check_expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/debugger/lazy_initializer_expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/debugger/list_processes_expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M tests/debugger/list_processes_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/debugger/nonempty_column_expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M tests/debugger/nonempty_column_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/debugger/parameter_mapping_expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/debugger/patch_regression_expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/debugger/patched_constructor_expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/debugger/print_local_structure_expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M tests/debugger/print_local_structure_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/debugger/simple_arithmetic_expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/debugger/string_interpolation_expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/debugger/switch_expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/debugger/uncaught_exceptions_expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M tests/debugger/uncaught_exceptions_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/debugger/unused_optional_expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M tests/debugger/unused_optional_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698