Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2029713002: Constructors for ui::MouseEvent/ui::TouchEvent from ui::PointerEvent. (Closed)

Created:
4 years, 6 months ago by Hadi
Modified:
4 years, 6 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Constructors for ui::MouseEvent/ui::TouchEvent from ui::PointerEvent. We don't support ui::PointerEvents in mus+ash client side right now, so we need to convert ui::PointerEvent to ui::MouseEvent/ui::TouchEvent until we have a better solution. This CL adds constructors we need so we can do this conversion. Previously this conversion happened when we deserialized mojom::Event to ui::Event, but that didn't seem the correct place to do it, since we serialized ui::PointerEvent (and not touch/mouse events) to mojom::Event, and we should get the same kind of object when deserializing. BUG=615094 Committed: https://crrev.com/ef4e847c615cc3fa778d84586578409d8d4f0895 Cr-Commit-Position: refs/heads/master@{#397236}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -0 lines) Patch
M ui/events/event.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/events/event.cc View 2 chunks +61 lines, -0 lines 0 comments Download
M ui/events/event_unittest.cc View 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Hadi
PTAL.
4 years, 6 months ago (2016-06-01 19:14:41 UTC) #3
sadrul
lgtm
4 years, 6 months ago (2016-06-01 19:57:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029713002/1
4 years, 6 months ago (2016-06-01 19:58:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 20:46:33 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 20:48:31 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef4e847c615cc3fa778d84586578409d8d4f0895
Cr-Commit-Position: refs/heads/master@{#397236}

Powered by Google App Engine
This is Rietveld 408576698