Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2029573002: Remove a Failure entry in TestExpectations (Closed)

Created:
4 years, 6 months ago by xidachen
Modified:
4 years, 6 months ago
Reviewers:
ajuma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a Failure entry in TestExpectations Run into this test under Debug mode, it is passing. PS#1: remove the entry, bots doesn't detect diff :( PS#2: had to add a blank line in a cpp file, bot runs fine :) PS#3: back to PS#1. Committed: https://crrev.com/06692e371cad3ad3708926cad59bc203761ab31e Cr-Commit-Position: refs/heads/master@{#397290}

Patch Set 1 #

Patch Set 2 : add a blank line in a cpp file so that the bot will run #

Patch Set 3 : back to PS1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029573002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029573002/40001
4 years, 6 months ago (2016-06-01 15:11:47 UTC) #4
xidachen
PTAL
4 years, 6 months ago (2016-06-01 15:48:51 UTC) #5
ajuma
lgtm
4 years, 6 months ago (2016-06-01 16:49:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029573002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029573002/40001
4 years, 6 months ago (2016-06-01 16:50:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029573002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029573002/40001
4 years, 6 months ago (2016-06-01 21:25:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029573002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029573002/40001
4 years, 6 months ago (2016-06-01 21:25:14 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-02 01:44:10 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 01:46:05 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/06692e371cad3ad3708926cad59bc203761ab31e
Cr-Commit-Position: refs/heads/master@{#397290}

Powered by Google App Engine
This is Rietveld 408576698