src/hydrogen.cc - Issue 20295005: Fix JSArray-specific length lookup in polymorphic array handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 20295005: Fix JSArray-specific length lookup in polymorphic array handling (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 7a761a392e78c77034c553748747606ad4e21a4d..97a66790e47d1ed41a0bd102d9331bac0041b658 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -5701,7 +5701,7 @@ HValue* HOptimizedGraphBuilder::HandlePolymorphicElementAccess(

elements, isolate()->factory()->fixed_array_map(),

zone(), top_info(), mapcompare));

}

- if (map->IsJSArray()) {

+ if (map->instance_type() == JS_ARRAY_TYPE) {

HInstruction* length = AddLoad(object, HObjectAccess::ForArrayLength(),

mapcompare, Representation::Smi());

length->set_type(HType::Smi());

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-263276.js » ('j') | no next file with comments »