Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Unified Diff: tools/perf/measurements/page_cycler.py

Issue 2029483002: [PCv1] Avoid using dot in metrics name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: keep old Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/measurements/page_cycler_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/page_cycler.py
diff --git a/tools/perf/measurements/page_cycler.py b/tools/perf/measurements/page_cycler.py
index c2245574abe07352e93c921ee358847ff7c09a20..370962bc9d5acddc7694112c7e91590eafefc707 100644
--- a/tools/perf/measurements/page_cycler.py
+++ b/tools/perf/measurements/page_cycler.py
@@ -10,7 +10,7 @@ time from navigationStart (immediately after the previous page's beforeunload
event) until after the layout in the page's load event. In addition, two garbage
collections are performed in between the page loads (in the beforeunload event).
This extra garbage collection time is not included in the measurement times.
-
+page_
nednguyen 2016/06/02 01:56:06 typo? :P
kouhei (in TOK) 2016/06/02 01:59:57 typo. Ack. Will fix and land
Finally, various memory and IO statistics are gathered at the very end of
cycling all pages.
"""
@@ -111,6 +111,23 @@ class PageCycler(legacy_page_test.LegacyPageTest):
'warm_')
results.AddValue(scalar.ScalarValue(
+ results.current_page, '%stimes-page_load_time' % chart_name_prefix,
+ 'ms', tab.EvaluateJavaScript('__pc_load_time'),
+ description='Average page load time. Measured from '
+ 'performance.timing.navigationStart until the completion '
+ 'time of a layout after the window.load event. Cold times '
+ 'are the times when the page is loaded cold, i.e. without '
+ 'loading it before, and warm times are times when the '
+ 'page is loaded after being loaded previously.'))
+ results.AddValue(scalar.ScalarValue(
+ results.current_page, '%stimes-time_to_onload' % chart_name_prefix,
+ 'ms', tab.EvaluateJavaScript('performance.timing.loadEventStart'
+ '- performance.timing.navigationStart'),
+ description='Time to onload. This is temporary metric to check that '
+ 'PCv1 and PCv2 emit similar results'))
+
+ # TODO(kouhei): Remove below. crbug.com/616342
+ results.AddValue(scalar.ScalarValue(
results.current_page, '%stimes.page_load_time' % chart_name_prefix,
'ms', tab.EvaluateJavaScript('__pc_load_time'),
description='Average page load time. Measured from '
« no previous file with comments | « no previous file | tools/perf/measurements/page_cycler_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698