Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Issue 2029453002: MD Settings: About page, implement obsolete/end-of-the-line status. (Closed)

Created:
4 years, 6 months ago by dpapad
Modified:
4 years, 6 months ago
Reviewers:
dschuyler
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: About page, implement obsolete/end-of-the-line status. BUG=603625 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f021733c8a6c844f77350f4b9ab65a8bf90d10c8 Cr-Commit-Position: refs/heads/master@{#397523}

Patch Set 1 : Resolve conflicts. #

Total comments: 2

Patch Set 2 : Addressing comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -18 lines) Patch
M chrome/browser/resources/settings/about_page/about_page.html View 1 2 chunks +19 lines, -12 lines 0 comments Download
M chrome/browser/resources/settings/about_page/about_page.js View 4 chunks +31 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/settings/about_handler.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/test/data/webui/settings/about_page_tests.js View 4 chunks +88 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
dpapad
Screenshots at http://imgur.com/a/o4hZl.
4 years, 6 months ago (2016-06-01 22:10:10 UTC) #7
dschuyler
LGTM with a nit/request. https://codereview.chromium.org/2029453002/diff/60001/chrome/browser/resources/settings/about_page/about_page.html File chrome/browser/resources/settings/about_page/about_page.html (right): https://codereview.chromium.org/2029453002/diff/60001/chrome/browser/resources/settings/about_page/about_page.html#newcode74 chrome/browser/resources/settings/about_page/about_page.html:74: src="[[getIconSrc_(currentUpdateStatusEvent_)]]"> nit: The line wrapping ...
4 years, 6 months ago (2016-06-01 22:37:11 UTC) #8
dpapad
https://codereview.chromium.org/2029453002/diff/60001/chrome/browser/resources/settings/about_page/about_page.html File chrome/browser/resources/settings/about_page/about_page.html (right): https://codereview.chromium.org/2029453002/diff/60001/chrome/browser/resources/settings/about_page/about_page.html#newcode74 chrome/browser/resources/settings/about_page/about_page.html:74: src="[[getIconSrc_(currentUpdateStatusEvent_)]]"> On 2016/06/01 at 22:37:11, dschuyler wrote: > nit: ...
4 years, 6 months ago (2016-06-01 23:38:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029453002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029453002/80001
4 years, 6 months ago (2016-06-01 23:50:17 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/170939)
4 years, 6 months ago (2016-06-02 02:31:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029453002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029453002/80001
4 years, 6 months ago (2016-06-02 17:34:15 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 6 months ago (2016-06-02 22:06:14 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 22:08:04 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f021733c8a6c844f77350f4b9ab65a8bf90d10c8
Cr-Commit-Position: refs/heads/master@{#397523}

Powered by Google App Engine
This is Rietveld 408576698