MD Settings: About page, implement obsolete/end-of-the-line status.

MD Settings: About page, implement obsolete/end-of-the-line status.

BUG=603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f021733c8a6c844f77350f4b9ab65a8bf90d10c8
Cr-Commit-Position: refs/heads/master@{#397523}

[dpapad, 2016-05-31 22:53:45]

Description was changed from

==========
MD Settings: About page, implement obsolete/end-of-the-line status, WIP.

BUG=
==========

to

==========
MD Settings: About page, implement obsolete/end-of-the-line status, WIP.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-06-01 21:31:46]

Patchset #2 (id:20001) has been deleted

[dpapad, 2016-06-01 21:31:50]

Patchset #1 (id:1) has been deleted

[dpapad, 2016-06-01 21:38:09]

Description was changed from

==========
MD Settings: About page, implement obsolete/end-of-the-line status, WIP.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: About page, implement obsolete/end-of-the-line status.

BUG=603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-06-01 22:02:40]

Patchset #1 (id:40001) has been deleted

[dpapad, 2016-06-01 22:10:07]

dpapad@chromium.org changed reviewers:
+ dschuyler@chromium.org

[dpapad, 2016-06-01 22:10:10]

Screenshots at http://imgur.com/a/o4hZl.

[dschuyler, 2016-06-01 22:37:11]

LGTM with a nit/request.

https://codereview.chromium.org/2029453002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/about_page/about_page.html (right):

https://codereview.chromium.org/2029453002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/about_page/about_page.html:74:
src="[[getIconSrc_(currentUpdateStatusEvent_)]]">
nit:
The line wrapping may be technically ok.
I find it harder to parse than I'd like. :)
How about this wrapping:

              <iron-icon
                  hidden="[[!shouldShowUpdateStatusIcon_(
                      currentUpdateStatusEvent_)]]"
                  icon$="[[getIcon_(currentUpdateStatusEvent_)]]"
                  src="[[getIconSrc_(currentUpdateStatusEvent_)]]">

[dpapad, 2016-06-01 23:38:14]

https://codereview.chromium.org/2029453002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/about_page/about_page.html (right):

https://codereview.chromium.org/2029453002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/about_page/about_page.html:74:
src="[[getIconSrc_(currentUpdateStatusEvent_)]]">
On 2016/06/01 at 22:37:11, dschuyler wrote:
> nit:
> The line wrapping may be technically ok.
> I find it harder to parse than I'd like. :)
> How about this wrapping:
> 
>               <iron-icon
>                   hidden="[[!shouldShowUpdateStatusIcon_(
>                       currentUpdateStatusEvent_)]]"
>                   icon$="[[getIcon_(currentUpdateStatusEvent_)]]"
>                   src="[[getIconSrc_(currentUpdateStatusEvent_)]]">

Done.

[dpapad, 2016-06-01 23:49:26]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-06-01 23:49:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/2029453002/#ps80001
(title: "Addressing comment.")

[commit-bot: I haz the power, 2016-06-01 23:50:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2029453002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2029453002/80001

[commit-bot: I haz the power, 2016-06-02 02:31:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 02:31:18]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dpapad, 2016-06-02 17:33:37]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-06-02 17:34:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2029453002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2029453002/80001

[commit-bot: I haz the power, 2016-06-02 22:06:14]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-06-02 22:08:03]

Description was changed from

==========
MD Settings: About page, implement obsolete/end-of-the-line status.

BUG=603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: About page, implement obsolete/end-of-the-line status.

BUG=603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f021733c8a6c844f77350f4b9ab65a8bf90d10c8
Cr-Commit-Position: refs/heads/master@{#397523}
==========

[commit-bot: I haz the power, 2016-06-02 22:08:04]

Patchset 2 (id:??) landed as
https://crrev.com/f021733c8a6c844f77350f4b9ab65a8bf90d10c8
Cr-Commit-Position: refs/heads/master@{#397523}