Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1620)

Unified Diff: content/renderer/render_view_impl.h

Issue 2029423003: OOPIF IME: Renderer Side Changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Using focusedCoreFrame() instead of focusController().focusedFrame() in WebViewImpl Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.h
diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h
index 25cfceb685950e353661e82364578711dadd28f6..66e952db4131d8f0c1cf9f1d6ecc9c8544b8c4f6 100644
--- a/content/renderer/render_view_impl.h
+++ b/content/renderer/render_view_impl.h
@@ -240,6 +240,10 @@ class CONTENT_EXPORT RenderViewImpl
// Plugin-related functions --------------------------------------------------
#if defined(ENABLE_PLUGINS)
+ // TODO(ekaramad): This method is only used by TextInputClientObserver.
+ // Ideally, TextInputClientObserver should use RenderFrame/RenderWidget to
+ // obtain the plugin. Come back to this later when implementing IME for Mac
+ // to see if we can remove this API (https://crbug.com/578168).
PepperPluginInstanceImpl* GetFocusedPepperPlugin();
#endif // ENABLE_PLUGINS
@@ -443,22 +447,7 @@ class CONTENT_EXPORT RenderViewImpl
void OnResize(const ResizeParams& params) override;
void OnSetFocus(bool enable) override;
GURL GetURLForGraphicsContext3D() override;
- void OnImeSetComposition(
- const base::string16& text,
- const std::vector<blink::WebCompositionUnderline>& underlines,
- const gfx::Range& replacement_range,
- int selection_start,
- int selection_end) override;
- void OnImeConfirmComposition(const base::string16& text,
- const gfx::Range& replacement_range,
- bool keep_selection) override;
void OnOrientationChange() override;
- ui::TextInputType GetTextInputType() override;
- void GetSelectionBounds(gfx::Rect* start, gfx::Rect* end) override;
- void GetCompositionCharacterBounds(
- std::vector<gfx::Rect>* character_bounds_in_window) override;
- void GetCompositionRange(gfx::Range* range) override;
- bool CanComposeInline() override;
void DidCommitCompositorFrame() override;
void DidCompletePageScaleAnimation() override;
void OnDeviceScaleFactorChanged() override;
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698