Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.h

Issue 2029423003: OOPIF IME: Renderer Side Changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing lfg@'s comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.h
diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.h b/third_party/WebKit/Source/web/WebFrameWidgetImpl.h
index e06018a46c41cc05817cd7f2de418344537acae2..97a107a8821a1bc8a93a0261190a95294f7ff4cd 100644
--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.h
+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.h
@@ -116,6 +116,8 @@ public:
void didAcquirePointerLock() override;
void didNotAcquirePointerLock() override;
void didLosePointerLock() override;
+ bool getCompositionCharacterBounds(WebVector<WebRect>& bounds) override;
+ void applyReplacementRange(int start, int length) override;
// WebFrameWidget implementation.
void setVisibilityState(WebPageVisibilityState) override;
@@ -195,6 +197,20 @@ private:
WebViewImpl* view() const { return m_localRoot->viewImpl(); }
+ // This method returns the focused frame belonging to this WebWidget, that
+ // is, a focused frame with the same local root as the one corresponding
+ // to this widget. It will return nullptr if no frame is focused or, the
+ // focused frame has a different local root.
+ LocalFrame* focusedLocalFrameInWidget() const;
+
+ bool confirmComposition(const WebString& text, ConfirmCompositionBehavior selectionBehavior) const;
+
+ WebPlugin* focusedPluginIfInputMethodSupported(LocalFrame*) const;
+
+ WebString inputModeOfFocusedElement() const;
+
+ int textInputFlags() const;
+
WebWidgetClient* m_client;
// WebFrameWidget is associated with a subtree of the frame tree, corresponding to a maximal
@@ -225,6 +241,9 @@ private:
// Whether the WebFrameWidget is rendering transparently.
bool m_isTransparent;
+ // Represents whether or not this object should process incoming IME events.
+ bool m_imeAcceptEvents;
+
static const WebInputEvent* m_currentInputEvent;
WebColor m_baseBackgroundColor;

Powered by Google App Engine
This is Rietveld 408576698