OOPIF IME: Renderer Side Changes

content/renderer/render_view_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 222 matching lines @@
 
   // Sets page-level focus in this view and notifies plugins and Blink's
   // FocusController.
   void SetFocus(bool enable);
 
   void AttachWebFrameWidget(blink::WebFrameWidget* frame_widget);
 
   // Plugin-related functions --------------------------------------------------
 
 #if defined(ENABLE_PLUGINS)
+  // TODO(ekaramad): This method is only used by TextInputClientObserver.
+  // Ideally, TextInputClientObserver should use RenderFrame/RenderWidget to
+  // obtain the plugin. Come back to this later when implementing IME for MAC

[Charlie Reis, 2016/07/12 00:00:12]

nit: s/MAC/Mac/

[EhsanK, 2016/07/12 15:13:24]

Done.

+  // to see if we can remove this API (https://crbug.com/578168).
   PepperPluginInstanceImpl* GetFocusedPepperPlugin();
 #endif  // ENABLE_PLUGINS
 
   void TransferActiveWheelFlingAnimation(
       const blink::WebActiveWheelFlingParameters& params);
 
   // Starts a timer to send an UpdateState message on behalf of |frame|, if the
   // timer isn't already running. This allows multiple state changing events to
   // be coalesced into one update.
   void StartNavStateSyncTimerIfNecessary(RenderFrameImpl* frame);
@@ skipping 185 matching lines @@
   // appropriate section, add it there. If not, there are some random functions
   // nearer to the top you can add it to.
 
  protected:
   // RenderWidget overrides:
   void CloseForFrame() override;
   void Close() override;
   void OnResize(const ResizeParams& params) override;
   void OnSetFocus(bool enable) override;
   GURL GetURLForGraphicsContext3D() override;
-  void OnImeSetComposition(
-      const base::string16& text,
-      const std::vector<blink::WebCompositionUnderline>& underlines,
-      const gfx::Range& replacement_range,
-      int selection_start,
-      int selection_end) override;
-  void OnImeConfirmComposition(const base::string16& text,
-                               const gfx::Range& replacement_range,
-                               bool keep_selection) override;
   void OnOrientationChange() override;
-  ui::TextInputType GetTextInputType() override;
-  void GetSelectionBounds(gfx::Rect* start, gfx::Rect* end) override;
-  void GetCompositionCharacterBounds(
-      std::vector<gfx::Rect>* character_bounds_in_window) override;
-  void GetCompositionRange(gfx::Range* range) override;
-  bool CanComposeInline() override;
   void DidCommitCompositorFrame() override;
   void DidCompletePageScaleAnimation() override;
   void OnDeviceScaleFactorChanged() override;
   void ResizeWebWidget() override;
 
   RenderViewImpl(CompositorDependencies* compositor_deps,
                  const ViewMsg_New_Params& params);
 
   void Initialize(const ViewMsg_New_Params& params,
                   bool was_created_by_renderer);
@@ skipping 466 matching lines @@
   // use the Observer interface to filter IPC messages and receive frame change
   // notifications.
   // ---------------------------------------------------------------------------
 
   DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_