gm/showmiplevels.cpp - Issue 2029373004: respect srgb gamma when building mips

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/showmiplevels.cpp

Issue 2029373004: respect srgb gamma when building mips (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Need to know when we're in L32 compatibility mode !!!? Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/showmiplevels.cpp

diff --git a/gm/showmiplevels.cpp b/gm/showmiplevels.cpp

index 717d629adecd4b83234fef355acec195d3dc3d34..e648b28a47ac22cf528d1a5c4f486c4963574e67 100644

--- a/gm/showmiplevels.cpp

+++ b/gm/showmiplevels.cpp

@@ -144,7 +144,8 @@ protected:

baseBM.lockPixels();

baseBM.peekPixels(&prevPM);

- SkAutoTUnref<SkMipMap> mm(SkMipMap::Build(baseBM, nullptr));

+ SkMipMap::SrcGammaMode mode = SkMipMap::kIgnore_SrcGammaMode;

+ SkAutoTUnref<SkMipMap> mm(SkMipMap::Build(baseBM, mode, nullptr));

int index = 0;

SkMipMap::Level level;

@@ -252,7 +253,8 @@ protected:

SkScalar x = 4;

SkScalar y = 4;

- SkAutoTUnref<SkMipMap> mm(SkMipMap::Build(baseBM, nullptr));

+ SkMipMap::SrcGammaMode mode = SkMipMap::kIgnore_SrcGammaMode;

+ SkAutoTUnref<SkMipMap> mm(SkMipMap::Build(baseBM, mode, nullptr));

int index = 0;

SkMipMap::Level level;