Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2029373002:
media: AVDA::QueueInput/DequeueOutput bail if state_ is invalid (Closed)
|
Created:
4 years, 6 months ago by watk Modified:
4 years, 6 months ago Reviewers:
DaleCurtis CC:
chromium-reviews, feature-media-reviews_chromium.org, liberato (no reviews please), piman+watch_chromium.org, posciak+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionmedia: AVDA::QueueInput/DequeueOutput bail if state_ is invalid
Previously AVDA::DoIOTask() checked that state_ was valid before
calling QueueInput and DequeueOutput. Now, because we call them
multiple times in a row, it's possible for state_ to change and
for it to be no longer valid to call them. This CL adds early
returns when the state is invalid.
BUG=612343, 612264
Committed: https://crrev.com/79b7deae415586f31d55268b9847610dde4e272e
Cr-Commit-Position: refs/heads/master@{#397480}
Patch Set 1 #
Messages
Total messages: 19 (9 generated)
watk@chromium.org changed reviewers: + dalecurtis@chromium.org
The CQ bit was checked by watk@chromium.org to run a CQ dry run
Nice catch, lgtm
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029373002/1
The CQ bit was unchecked by watk@chromium.org
The CQ bit was checked by watk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029373002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dalecurtis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029373002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by watk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029373002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== media: AVDA::QueueInput/DequeueOutput bail if state_ is invalid Previously AVDA::DoIOTask() checked that state_ was valid before calling QueueInput and DequeueOutput. Now, because we call them multiple times in a row, it's possible for state_ to change and for it to be no longer valid to call them. This CL adds early returns when the state is invalid. BUG=612343,612264 ========== to ========== media: AVDA::QueueInput/DequeueOutput bail if state_ is invalid Previously AVDA::DoIOTask() checked that state_ was valid before calling QueueInput and DequeueOutput. Now, because we call them multiple times in a row, it's possible for state_ to change and for it to be no longer valid to call them. This CL adds early returns when the state is invalid. BUG=612343,612264 Committed: https://crrev.com/79b7deae415586f31d55268b9847610dde4e272e Cr-Commit-Position: refs/heads/master@{#397480} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/79b7deae415586f31d55268b9847610dde4e272e Cr-Commit-Position: refs/heads/master@{#397480} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
