Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 2029363002: Show dropdown button in download shelf items for malicious DLs. (Closed)

Created:
4 years, 6 months ago by Evan Stade
Modified:
4 years, 6 months ago
Reviewers:
asanka, sky
CC:
asanka, chromium-reviews, dbeam+watch-downloads_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show dropdown button in download shelf items for malicious DLs. Dangerous ones still don't show the button. This was an oversight concerning the difference between malicious and dangerous. BUG=616615 Committed: https://crrev.com/64acfeb29cfa3ac2dd7e98d3946fafce7ae2aeaa Cr-Commit-Position: refs/heads/master@{#397815}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M chrome/browser/ui/views/download/download_item_view_md.cc View 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Evan Stade
4 years, 6 months ago (2016-06-01 23:54:01 UTC) #2
asanka
lgtm
4 years, 6 months ago (2016-06-02 14:21:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029363002/1
4 years, 6 months ago (2016-06-02 19:42:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/194139)
4 years, 6 months ago (2016-06-02 19:56:50 UTC) #7
Evan Stade
+sky for owners
4 years, 6 months ago (2016-06-02 23:53:11 UTC) #9
sky
LGTM
4 years, 6 months ago (2016-06-03 15:09:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029363002/1
4 years, 6 months ago (2016-06-03 19:08:28 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 21:52:21 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 21:53:38 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64acfeb29cfa3ac2dd7e98d3946fafce7ae2aeaa
Cr-Commit-Position: refs/heads/master@{#397815}

Powered by Google App Engine
This is Rietveld 408576698