Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1049)

Side by Side Diff: cc/surfaces/surface_display_output_surface_unittest.cc

Issue 2029323004: Get rid of virtual Display::CreateScheduler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onscreendisplayclient
Patch Set: displaytest: ownership-all-the-things Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/surfaces/surface_display_output_surface.h" 5 #include "cc/surfaces/surface_display_output_surface.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "cc/output/renderer_settings.h" 9 #include "cc/output/renderer_settings.h"
10 #include "cc/output/texture_mailbox_deleter.h"
10 #include "cc/scheduler/begin_frame_source.h" 11 #include "cc/scheduler/begin_frame_source.h"
11 #include "cc/surfaces/display.h" 12 #include "cc/surfaces/display.h"
13 #include "cc/surfaces/display_scheduler.h"
12 #include "cc/surfaces/surface_id_allocator.h" 14 #include "cc/surfaces/surface_id_allocator.h"
13 #include "cc/surfaces/surface_manager.h" 15 #include "cc/surfaces/surface_manager.h"
14 #include "cc/test/fake_output_surface.h" 16 #include "cc/test/fake_output_surface.h"
15 #include "cc/test/fake_output_surface_client.h" 17 #include "cc/test/fake_output_surface_client.h"
16 #include "cc/test/ordered_simple_task_runner.h" 18 #include "cc/test/ordered_simple_task_runner.h"
17 #include "cc/test/test_context_provider.h" 19 #include "cc/test/test_context_provider.h"
18 #include "cc/test/test_gpu_memory_buffer_manager.h" 20 #include "cc/test/test_gpu_memory_buffer_manager.h"
19 #include "cc/test/test_shared_bitmap_manager.h" 21 #include "cc/test/test_shared_bitmap_manager.h"
20 #include "testing/gtest/include/gtest/gtest.h" 22 #include "testing/gtest/include/gtest/gtest.h"
21 23
22 namespace cc { 24 namespace cc {
23 namespace { 25 namespace {
24 26
25 class SurfaceDisplayOutputSurfaceTest : public testing::Test { 27 class SurfaceDisplayOutputSurfaceTest : public testing::Test {
26 public: 28 public:
27 SurfaceDisplayOutputSurfaceTest() 29 SurfaceDisplayOutputSurfaceTest()
28 : now_src_(new base::SimpleTestTickClock()), 30 : now_src_(new base::SimpleTestTickClock()),
29 task_runner_(new OrderedSimpleTaskRunner(now_src_.get(), true)), 31 task_runner_(new OrderedSimpleTaskRunner(now_src_.get(), true)),
30 begin_frame_source_(new BackToBackBeginFrameSource(task_runner_.get())),
31 allocator_(0), 32 allocator_(0),
32 display_size_(1920, 1080), 33 display_size_(1920, 1080),
33 display_rect_(display_size_), 34 display_rect_(display_size_),
34 context_provider_(TestContextProvider::Create()) { 35 context_provider_(TestContextProvider::Create()) {
35 surface_manager_.RegisterSurfaceIdNamespace(allocator_.id_namespace()); 36 surface_manager_.RegisterSurfaceIdNamespace(allocator_.id_namespace());
36 37
37 std::unique_ptr<FakeOutputSurface> display_output_surface = 38 std::unique_ptr<FakeOutputSurface> display_output_surface =
38 FakeOutputSurface::Create3d(); 39 FakeOutputSurface::Create3d();
39 display_output_surface_ = display_output_surface.get(); 40 display_output_surface_ = display_output_surface.get();
40 display_output_surface_->set_max_frames_pending(2);
41 41
42 display_.reset(new Display(&surface_manager_, &bitmap_manager_, 42 std::unique_ptr<BeginFrameSource> begin_frame_source(
43 &gpu_memory_buffer_manager_, renderer_settings_, 43 new BackToBackBeginFrameSource(task_runner_.get()));
44 allocator_.id_namespace(), task_runner_.get(), 44
45 std::move(display_output_surface))); 45 int max_frames_pending = 2;
46 std::unique_ptr<DisplayScheduler> scheduler(new DisplayScheduler(
47 begin_frame_source.get(), task_runner_.get(), max_frames_pending));
48
49 display_.reset(new Display(
50 &surface_manager_, &bitmap_manager_, &gpu_memory_buffer_manager_,
51 renderer_settings_, allocator_.id_namespace(),
52 std::move(begin_frame_source), std::move(display_output_surface),
53 std::move(scheduler),
54 base::MakeUnique<TextureMailboxDeleter>(task_runner_.get())));
46 delegated_output_surface_.reset(new SurfaceDisplayOutputSurface( 55 delegated_output_surface_.reset(new SurfaceDisplayOutputSurface(
47 &surface_manager_, &allocator_, display_.get(), context_provider_, 56 &surface_manager_, &allocator_, display_.get(), context_provider_,
48 nullptr)); 57 nullptr));
49 58
50 // Set the Display's begin frame source like a real browser compositor
51 // output surface would.
52 display_->SetBeginFrameSource(begin_frame_source_.get());
53 delegated_output_surface_->BindToClient(&delegated_output_surface_client_); 59 delegated_output_surface_->BindToClient(&delegated_output_surface_client_);
54 display_->Resize(display_size_); 60 display_->Resize(display_size_);
55 61
56 EXPECT_FALSE( 62 EXPECT_FALSE(
57 delegated_output_surface_client_.did_lose_output_surface_called()); 63 delegated_output_surface_client_.did_lose_output_surface_called());
58 } 64 }
59 65
60 ~SurfaceDisplayOutputSurfaceTest() override {} 66 ~SurfaceDisplayOutputSurfaceTest() override {}
61 67
62 void SwapBuffersWithDamage(const gfx::Rect& damage_rect) { 68 void SwapBuffersWithDamage(const gfx::Rect& damage_rect) {
(...skipping 15 matching lines...) Expand all
78 SwapBuffersWithDamage(display_rect_); 84 SwapBuffersWithDamage(display_rect_);
79 85
80 EXPECT_EQ(0u, display_output_surface_->num_sent_frames()); 86 EXPECT_EQ(0u, display_output_surface_->num_sent_frames());
81 task_runner_->RunUntilIdle(); 87 task_runner_->RunUntilIdle();
82 EXPECT_EQ(1u, display_output_surface_->num_sent_frames()); 88 EXPECT_EQ(1u, display_output_surface_->num_sent_frames());
83 } 89 }
84 90
85 protected: 91 protected:
86 std::unique_ptr<base::SimpleTestTickClock> now_src_; 92 std::unique_ptr<base::SimpleTestTickClock> now_src_;
87 scoped_refptr<OrderedSimpleTaskRunner> task_runner_; 93 scoped_refptr<OrderedSimpleTaskRunner> task_runner_;
88 std::unique_ptr<BackToBackBeginFrameSource> begin_frame_source_;
89 SurfaceIdAllocator allocator_; 94 SurfaceIdAllocator allocator_;
90 95
91 const gfx::Size display_size_; 96 const gfx::Size display_size_;
92 const gfx::Rect display_rect_; 97 const gfx::Rect display_rect_;
93 SurfaceManager surface_manager_; 98 SurfaceManager surface_manager_;
94 TestSharedBitmapManager bitmap_manager_; 99 TestSharedBitmapManager bitmap_manager_;
95 TestGpuMemoryBufferManager gpu_memory_buffer_manager_; 100 TestGpuMemoryBufferManager gpu_memory_buffer_manager_;
96 RendererSettings renderer_settings_; 101 RendererSettings renderer_settings_;
97 102
98 scoped_refptr<TestContextProvider> context_provider_; 103 scoped_refptr<TestContextProvider> context_provider_;
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 EXPECT_EQ(1u, display_output_surface_->num_sent_frames()); 144 EXPECT_EQ(1u, display_output_surface_->num_sent_frames());
140 145
141 SwapBuffersWithDamage(gfx::Rect()); 146 SwapBuffersWithDamage(gfx::Rect());
142 EXPECT_EQ(1u, display_output_surface_->num_sent_frames()); 147 EXPECT_EQ(1u, display_output_surface_->num_sent_frames());
143 task_runner_->RunUntilIdle(); 148 task_runner_->RunUntilIdle();
144 EXPECT_EQ(1u, display_output_surface_->num_sent_frames()); 149 EXPECT_EQ(1u, display_output_surface_->num_sent_frames());
145 } 150 }
146 151
147 } // namespace 152 } // namespace
148 } // namespace cc 153 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698