Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc

Issue 2029323004: Get rid of virtual Display::CreateScheduler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onscreendisplayclient
Patch Set: displaytest: unusedvar Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/compositor/gpu_surfaceless_browser_compositor_output_s urface.h" 5 #include "content/browser/compositor/gpu_surfaceless_browser_compositor_output_s urface.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "cc/output/compositor_frame.h" 9 #include "cc/output/compositor_frame.h"
10 #include "cc/output/output_surface_client.h" 10 #include "cc/output/output_surface_client.h"
11 #include "components/display_compositor/buffer_queue.h" 11 #include "components/display_compositor/buffer_queue.h"
12 #include "components/display_compositor/compositor_overlay_candidate_validator.h " 12 #include "components/display_compositor/compositor_overlay_candidate_validator.h "
13 #include "components/display_compositor/gl_helper.h" 13 #include "components/display_compositor/gl_helper.h"
14 #include "content/browser/compositor/reflector_impl.h" 14 #include "content/browser/compositor/reflector_impl.h"
15 #include "content/common/gpu/client/context_provider_command_buffer.h" 15 #include "content/common/gpu/client/context_provider_command_buffer.h"
16 #include "gpu/GLES2/gl2extchromium.h" 16 #include "gpu/GLES2/gl2extchromium.h"
17 #include "gpu/command_buffer/client/gles2_interface.h" 17 #include "gpu/command_buffer/client/gles2_interface.h"
18 18
19 namespace content { 19 namespace content {
20 20
21 GpuSurfacelessBrowserCompositorOutputSurface:: 21 GpuSurfacelessBrowserCompositorOutputSurface::
22 GpuSurfacelessBrowserCompositorOutputSurface( 22 GpuSurfacelessBrowserCompositorOutputSurface(
23 scoped_refptr<ContextProviderCommandBuffer> context, 23 scoped_refptr<ContextProviderCommandBuffer> context,
24 gpu::SurfaceHandle surface_handle, 24 gpu::SurfaceHandle surface_handle,
25 scoped_refptr<ui::CompositorVSyncManager> vsync_manager, 25 scoped_refptr<ui::CompositorVSyncManager> vsync_manager,
26 base::SingleThreadTaskRunner* task_runner, 26 cc::SyntheticBeginFrameSource* begin_frame_source,
27 std::unique_ptr<display_compositor::CompositorOverlayCandidateValidator> 27 std::unique_ptr<display_compositor::CompositorOverlayCandidateValidator>
28 overlay_candidate_validator, 28 overlay_candidate_validator,
29 unsigned int target, 29 unsigned int target,
30 unsigned int internalformat, 30 unsigned int internalformat,
31 gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager) 31 gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager)
32 : GpuBrowserCompositorOutputSurface(std::move(context), 32 : GpuBrowserCompositorOutputSurface(std::move(context),
33 std::move(vsync_manager), 33 std::move(vsync_manager),
34 task_runner, 34 begin_frame_source,
35 std::move(overlay_candidate_validator)), 35 std::move(overlay_candidate_validator)),
36 internalformat_(internalformat), 36 internalformat_(internalformat),
37 gpu_memory_buffer_manager_(gpu_memory_buffer_manager) { 37 gpu_memory_buffer_manager_(gpu_memory_buffer_manager) {
38 capabilities_.uses_default_gl_framebuffer = false; 38 capabilities_.uses_default_gl_framebuffer = false;
39 capabilities_.flipped_output_surface = true; 39 capabilities_.flipped_output_surface = true;
40 // Set |max_frames_pending| to 2 for surfaceless, which aligns scheduling 40 // Set |max_frames_pending| to 2 for surfaceless, which aligns scheduling
41 // more closely with the previous surfaced behavior. 41 // more closely with the previous surfaced behavior.
42 // With a surface, swap buffer ack used to return early, before actually 42 // With a surface, swap buffer ack used to return early, before actually
43 // presenting the back buffer, enabling the browser compositor to run ahead. 43 // presenting the back buffer, enabling the browser compositor to run ahead.
44 // Surfaceless implementation acks at the time of actual buffer swap, which 44 // Surfaceless implementation acks at the time of actual buffer swap, which
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 buffer_queue_->RecreateBuffers(); 107 buffer_queue_->RecreateBuffers();
108 force_swap = true; 108 force_swap = true;
109 } 109 }
110 GpuBrowserCompositorOutputSurface::OnGpuSwapBuffersCompleted( 110 GpuBrowserCompositorOutputSurface::OnGpuSwapBuffersCompleted(
111 latency_info, result, params_mac); 111 latency_info, result, params_mac);
112 if (force_swap) 112 if (force_swap)
113 client_->SetNeedsRedrawRect(gfx::Rect(SurfaceSize())); 113 client_->SetNeedsRedrawRect(gfx::Rect(SurfaceSize()));
114 } 114 }
115 115
116 } // namespace content 116 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698