mash: Convert AshPopupAlignmentDelegate to wm common types

mash: Convert AshPopupAlignmentDelegate to wm common types

This is a dependency of WebNotificationTray, which is a dependency of
StatusAreaWidget, which I am trying to migrate to wm common types.

* Add auto-hide and work area methods to WmShelf.
* Access shelf_widget() via shelf_layout_manager() in WmShelfAura, as we need
to access it before the |Shelf| is created during external monitor init.

BUG=619636
TEST=ash_unittests

Committed: https://crrev.com/3228109cfdac49a405bbd039a4b4456097be9dd7
Cr-Commit-Position: refs/heads/master@{#400312}

[James Cook, 2016-06-16 18:19:35]

Description was changed from

==========
WIP: Change ash/system/tray/web_notification to wm common types
BUG=
==========

to

==========
mash: Convert AshPopupAlignmentDelegate to wm common types

This is a dependency of WebNotificationTray, which is a dependency of
StatusAreaWidget, which I am trying to migrate to wm common.

* Add auto-hide and work area methods to WmShelf.
* Access shelf_widget() via shelf_layout_manager() in WmShelfAura, as we need
to access it before the |Shelf| is created during external monitor init.

BUG=619636
TEST=ash_unittests
==========

[James Cook, 2016-06-16 18:20:06]

Description was changed from

==========
mash: Convert AshPopupAlignmentDelegate to wm common types

This is a dependency of WebNotificationTray, which is a dependency of
StatusAreaWidget, which I am trying to migrate to wm common.

* Add auto-hide and work area methods to WmShelf.
* Access shelf_widget() via shelf_layout_manager() in WmShelfAura, as we need
to access it before the |Shelf| is created during external monitor init.

BUG=619636
TEST=ash_unittests
==========

to

==========
mash: Convert AshPopupAlignmentDelegate to wm common types

This is a dependency of WebNotificationTray, which is a dependency of
StatusAreaWidget, which I am trying to migrate to wm common types.

* Add auto-hide and work area methods to WmShelf.
* Access shelf_widget() via shelf_layout_manager() in WmShelfAura, as we need
to access it before the |Shelf| is created during external monitor init.

BUG=619636
TEST=ash_unittests
==========

[James Cook, 2016-06-16 18:22:13]

Description was changed from

==========
mash: Convert AshPopupAlignmentDelegate to wm common types

This is a dependency of WebNotificationTray, which is a dependency of
StatusAreaWidget, which I am trying to migrate to wm common types.

* Add auto-hide and work area methods to WmShelf.
* Access shelf_widget() via shelf_layout_manager() in WmShelfAura, as we need
to access it before the |Shelf| is created during external monitor init.

BUG=619636
TEST=ash_unittests
==========

to

==========
mash: Convert AshPopupAlignmentDelegate to wm common types

This is a dependency of WebNotificationTray, which is a dependency of
StatusAreaWidget, which I am trying to migrate to wm common types.

* Add auto-hide and work area methods to WmShelf.
* Access shelf_widget() via shelf_layout_manager() in WmShelfAura, as we need
to access it before the |Shelf| is created during external monitor init.

BUG=619636
TEST=ash_unittests
==========

[James Cook, 2016-06-16 18:22:29]

Patchset #2 (id:20001) has been deleted

[James Cook, 2016-06-16 18:23:58]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-06-16 18:23:59]

msw, please take a look.

[msw, 2016-06-16 18:56:48]

Ugh, shelf init is miserable... lgtm, I guess.

https://codereview.chromium.org/2029323002/diff/40001/ash/aura/wm_shelf_aura.cc
File ash/aura/wm_shelf_aura.cc (right):

https://codereview.chromium.org/2029323002/diff/40001/ash/aura/wm_shelf_aura....
ash/aura/wm_shelf_aura.cc:68: shelf_->SetAlignment(alignment);
nit: null checks in setters, etc. too?

https://codereview.chromium.org/2029323002/diff/40001/ash/shelf/shelf.cc
File ash/shelf/shelf.cc (right):

https://codereview.chromium.org/2029323002/diff/40001/ash/shelf/shelf.cc#newc...
ash/shelf/shelf.cc:18: #include "ash/root_window_settings.h"
nit: remove if not needed.

https://codereview.chromium.org/2029323002/diff/40001/ash/system/web_notifica...
File ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
(right):

https://codereview.chromium.org/2029323002/diff/40001/ash/system/web_notifica...
ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc:35:
WmShelf* GetPrimaryShelf() {
nit: Add to AshTestBase? We'll likely need this (or lookup by display id or
similar) for other tests.

[James Cook, 2016-06-16 21:08:14]

https://codereview.chromium.org/2029323002/diff/40001/ash/aura/wm_shelf_aura.cc
File ash/aura/wm_shelf_aura.cc (right):

https://codereview.chromium.org/2029323002/diff/40001/ash/aura/wm_shelf_aura....
ash/aura/wm_shelf_aura.cc:68: shelf_->SetAlignment(alignment);
On 2016/06/16 18:56:48, msw wrote:
> nit: null checks in setters, etc. too?

Actually, I went the other way and only added the null checks that I absolutely
needed. In general I would prefer a setter to crash if called too early, rather
than do nothing. I'd like the getters to do that too, but I can't do that in
some cases.

https://codereview.chromium.org/2029323002/diff/40001/ash/shelf/shelf.cc
File ash/shelf/shelf.cc (right):

https://codereview.chromium.org/2029323002/diff/40001/ash/shelf/shelf.cc#newc...
ash/shelf/shelf.cc:18: #include "ash/root_window_settings.h"
On 2016/06/16 18:56:48, msw wrote:
> nit: remove if not needed.

Nice catch. Done.

https://codereview.chromium.org/2029323002/diff/40001/ash/system/web_notifica...
File ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
(right):

https://codereview.chromium.org/2029323002/diff/40001/ash/system/web_notifica...
ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc:35:
WmShelf* GetPrimaryShelf() {
On 2016/06/16 18:56:48, msw wrote:
> nit: Add to AshTestBase? We'll likely need this (or lookup by display id or
> similar) for other tests.

Moved to AshTestBase.

[James Cook, 2016-06-16 21:08:43]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-06-16 21:08:43]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2029323002/#ps60001
(title: "review comments")

[commit-bot: I haz the power, 2016-06-16 21:09:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2029323002/60001

[commit-bot: I haz the power, 2016-06-17 00:22:09]

Description was changed from

==========
mash: Convert AshPopupAlignmentDelegate to wm common types

This is a dependency of WebNotificationTray, which is a dependency of
StatusAreaWidget, which I am trying to migrate to wm common types.

* Add auto-hide and work area methods to WmShelf.
* Access shelf_widget() via shelf_layout_manager() in WmShelfAura, as we need
to access it before the |Shelf| is created during external monitor init.

BUG=619636
TEST=ash_unittests
==========

to

==========
mash: Convert AshPopupAlignmentDelegate to wm common types

This is a dependency of WebNotificationTray, which is a dependency of
StatusAreaWidget, which I am trying to migrate to wm common types.

* Add auto-hide and work area methods to WmShelf.
* Access shelf_widget() via shelf_layout_manager() in WmShelfAura, as we need
to access it before the |Shelf| is created during external monitor init.

BUG=619636
TEST=ash_unittests
==========

[commit-bot: I haz the power, 2016-06-17 00:22:10]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-06-17 00:23:58]

Description was changed from

==========
mash: Convert AshPopupAlignmentDelegate to wm common types

This is a dependency of WebNotificationTray, which is a dependency of
StatusAreaWidget, which I am trying to migrate to wm common types.

* Add auto-hide and work area methods to WmShelf.
* Access shelf_widget() via shelf_layout_manager() in WmShelfAura, as we need
to access it before the |Shelf| is created during external monitor init.

BUG=619636
TEST=ash_unittests
==========

to

==========
mash: Convert AshPopupAlignmentDelegate to wm common types

This is a dependency of WebNotificationTray, which is a dependency of
StatusAreaWidget, which I am trying to migrate to wm common types.

* Add auto-hide and work area methods to WmShelf.
* Access shelf_widget() via shelf_layout_manager() in WmShelfAura, as we need
to access it before the |Shelf| is created during external monitor init.

BUG=619636
TEST=ash_unittests

Committed: https://crrev.com/3228109cfdac49a405bbd039a4b4456097be9dd7
Cr-Commit-Position: refs/heads/master@{#400312}
==========

[commit-bot: I haz the power, 2016-06-17 00:23:59]

Patchset 3 (id:??) landed as
https://crrev.com/3228109cfdac49a405bbd039a4b4456097be9dd7
Cr-Commit-Position: refs/heads/master@{#400312}