Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2029303002: Start pulling apart ClassElementImpl and EnumElementImpl. (Closed)

Created:
4 years, 6 months ago by scheglov
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Start pulling apart ClassElementImpl and EnumElementImpl. So far just moving data and accessors for this data, which exist only in ClassElementImpl into this class. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/be47b2121eded7a3732b00534b0c914f9418ec52

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+660 lines, -664 lines) Patch
M pkg/analyzer/lib/src/dart/element/builder.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 22 chunks +630 lines, -641 lines 2 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 3 chunks +13 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 3 chunks +9 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/index_unit_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
4 years, 6 months ago (2016-06-01 21:36:05 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/2029303002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart (right): https://codereview.chromium.org/2029303002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart#newcode3006 pkg/analyzer/lib/src/dart/element/element.dart:3006: List<ConstructorElement> get constructors => const <ConstructorElement>[]; Can we ...
4 years, 6 months ago (2016-06-01 21:47:02 UTC) #2
Brian Wilkerson
lgtm
4 years, 6 months ago (2016-06-01 22:18:22 UTC) #3
scheglov
https://codereview.chromium.org/2029303002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart (right): https://codereview.chromium.org/2029303002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart#newcode3006 pkg/analyzer/lib/src/dart/element/element.dart:3006: List<ConstructorElement> get constructors => const <ConstructorElement>[]; On 2016/06/01 21:47:02, ...
4 years, 6 months ago (2016-06-02 00:13:25 UTC) #4
scheglov
4 years, 6 months ago (2016-06-02 00:13:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
be47b2121eded7a3732b00534b0c914f9418ec52 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698