Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2029293002:
Handle all context lost reasons when determining guilt of domain. (Closed)
|
Created:
4 years, 6 months ago by Ken Russell (switch to Gerrit) Modified:
4 years, 6 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionHandle all context lost reasons when determining guilt of domain.
This avoids a NOTREACHED() in the previous code. Verified that addition
of new constants without updating the switch statement will cause a
compile failure.
BUG=615113
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/c27c10b334e930d5569aafdf8c7d167f034708c5
Cr-Commit-Position: refs/heads/master@{#397906}
Patch Set 1 #Patch Set 2 : Initialize variable. #
Messages
Total messages: 27 (13 generated)
Description was changed from ========== Handle all context lost reasons when determining guilt of domain. This avoids a NOTREACHED() in the previous code. Verified that addition of new constants without updating the switch statement will cause a compile failure. BUG=615113 ========== to ========== Handle all context lost reasons when determining guilt of domain. This avoids a NOTREACHED() in the previous code. Verified that addition of new constants without updating the switch statement will cause a compile failure. BUG=615113 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
kbr@chromium.org changed reviewers: + sievers@chromium.org, zmo@chromium.org
zmo or sievers: please review. Thanks.
On 2016/06/01 21:29:12, Ken Russell wrote: > zmo or sievers: please review. Thanks. lgtm
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029293002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
The CQ bit was checked by kbr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org Link to the patchset: https://codereview.chromium.org/2029293002/#ps20001 (title: "Initialize variable.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029293002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_optional_gpu_tests_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029293002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029293002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029293002/20001
On 2016/06/03 05:43:21, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) http://crbug.com/616483
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Handle all context lost reasons when determining guilt of domain. This avoids a NOTREACHED() in the previous code. Verified that addition of new constants without updating the switch statement will cause a compile failure. BUG=615113 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Handle all context lost reasons when determining guilt of domain. This avoids a NOTREACHED() in the previous code. Verified that addition of new constants without updating the switch statement will cause a compile failure. BUG=615113 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/c27c10b334e930d5569aafdf8c7d167f034708c5 Cr-Commit-Position: refs/heads/master@{#397906} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c27c10b334e930d5569aafdf8c7d167f034708c5 Cr-Commit-Position: refs/heads/master@{#397906} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
