Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2029273002: PPC: Sign-extended result in DoFlooringDivI/DoDivI on 64bit (Closed)

Created:
4 years, 6 months ago by JaideepBajwa
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Sign-extended result in DoFlooringDivI/DoDivI on 64bit result is sign-extended on 64bit for functions LCodeGen::DoFlooringDivI and LCodeGen::DoDivI R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/6f76cc567db94e59ab1655e3825a314e08b54c47 Cr-Commit-Position: refs/heads/master@{#36661}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 6 months ago (2016-06-01 20:59:35 UTC) #1
JoranSiu
On 2016/06/01 20:59:35, JaideepBajwa wrote: > PTAL lgtm
4 years, 6 months ago (2016-06-01 22:02:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029273002/1
4 years, 6 months ago (2016-06-02 00:16:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 00:44:15 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 00:45:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f76cc567db94e59ab1655e3825a314e08b54c47
Cr-Commit-Position: refs/heads/master@{#36661}

Powered by Google App Engine
This is Rietveld 408576698