Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Side by Side Diff: chrome/browser/ui/webui/settings/md_settings_ui.cc

Issue 2029263002: [MD Settings] Add feature to enable md-settings by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review fixes. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/settings/md_settings_ui.h" 5 #include "chrome/browser/ui/webui/settings/md_settings_ui.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 10
11 #include "base/feature_list.h"
11 #include "base/metrics/histogram_macros.h" 12 #include "base/metrics/histogram_macros.h"
12 #include "chrome/browser/profiles/profile.h" 13 #include "chrome/browser/profiles/profile.h"
13 #include "chrome/browser/ui/webui/settings/about_handler.h" 14 #include "chrome/browser/ui/webui/settings/about_handler.h"
14 #include "chrome/browser/ui/webui/settings/appearance_handler.h" 15 #include "chrome/browser/ui/webui/settings/appearance_handler.h"
15 #include "chrome/browser/ui/webui/settings/downloads_handler.h" 16 #include "chrome/browser/ui/webui/settings/downloads_handler.h"
16 #include "chrome/browser/ui/webui/settings/font_handler.h" 17 #include "chrome/browser/ui/webui/settings/font_handler.h"
17 #include "chrome/browser/ui/webui/settings/languages_handler.h" 18 #include "chrome/browser/ui/webui/settings/languages_handler.h"
18 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provide r.h" 19 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provide r.h"
19 #include "chrome/browser/ui/webui/settings/people_handler.h" 20 #include "chrome/browser/ui/webui/settings/people_handler.h"
20 #include "chrome/browser/ui/webui/settings/profile_info_handler.h" 21 #include "chrome/browser/ui/webui/settings/profile_info_handler.h"
21 #include "chrome/browser/ui/webui/settings/reset_settings_handler.h" 22 #include "chrome/browser/ui/webui/settings/reset_settings_handler.h"
22 #include "chrome/browser/ui/webui/settings/search_engines_handler.h" 23 #include "chrome/browser/ui/webui/settings/search_engines_handler.h"
23 #include "chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler. h" 24 #include "chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler. h"
24 #include "chrome/browser/ui/webui/settings/settings_page_ui_handler.h" 25 #include "chrome/browser/ui/webui/settings/settings_page_ui_handler.h"
25 #include "chrome/browser/ui/webui/settings/settings_startup_pages_handler.h" 26 #include "chrome/browser/ui/webui/settings/settings_startup_pages_handler.h"
26 #include "chrome/browser/ui/webui/settings/site_settings_handler.h" 27 #include "chrome/browser/ui/webui/settings/site_settings_handler.h"
28 #include "chrome/common/chrome_features.h"
27 #include "chrome/common/url_constants.h" 29 #include "chrome/common/url_constants.h"
28 #include "content/public/browser/web_contents.h" 30 #include "content/public/browser/web_contents.h"
29 #include "content/public/browser/web_ui.h" 31 #include "content/public/browser/web_ui.h"
30 #include "content/public/browser/web_ui_data_source.h" 32 #include "content/public/browser/web_ui_data_source.h"
31 #include "grit/settings_resources.h" 33 #include "grit/settings_resources.h"
32 #include "grit/settings_resources_map.h" 34 #include "grit/settings_resources_map.h"
33 35
34 #if defined(OS_CHROMEOS) 36 #if defined(OS_CHROMEOS)
35 #include "chrome/browser/ui/webui/settings/chromeos/change_picture_handler.h" 37 #include "chrome/browser/ui/webui/settings/chromeos/change_picture_handler.h"
36 #include "chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.h" 38 #include "chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.h"
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 75
74 #if defined(OS_CHROMEOS) 76 #if defined(OS_CHROMEOS)
75 AddSettingsPageUIHandler(new chromeos::settings::ChangePictureHandler()); 77 AddSettingsPageUIHandler(new chromeos::settings::ChangePictureHandler());
76 AddSettingsPageUIHandler(new chromeos::settings::KeyboardHandler(web_ui)); 78 AddSettingsPageUIHandler(new chromeos::settings::KeyboardHandler(web_ui));
77 #else 79 #else
78 AddSettingsPageUIHandler(new DefaultBrowserHandler(web_ui)); 80 AddSettingsPageUIHandler(new DefaultBrowserHandler(web_ui));
79 AddSettingsPageUIHandler(new ManageProfileHandler(profile)); 81 AddSettingsPageUIHandler(new ManageProfileHandler(profile));
80 AddSettingsPageUIHandler(new SystemHandler()); 82 AddSettingsPageUIHandler(new SystemHandler());
81 #endif 83 #endif
82 84
83 content::WebUIDataSource* html_source = 85 // Host must be derived from the visible URL, since this might be serving
84 content::WebUIDataSource::Create(chrome::kChromeUIMdSettingsHost); 86 // either chrome://settings or chrome://md-settings.
Dan Beam 2016/06/03 03:01:43 if you're worried about it, const GURL url = web_
groby-ooo-7-16 2016/06/06 20:11:59 Done. And given that this is a possible privilege
87 content::WebUIDataSource* html_source = content::WebUIDataSource::Create(
88 web_ui->GetWebContents()->GetVisibleURL().host());
85 89
86 #if defined(OS_CHROMEOS) 90 #if defined(OS_CHROMEOS)
87 chromeos::settings::EasyUnlockSettingsHandler* easy_unlock_handler = 91 chromeos::settings::EasyUnlockSettingsHandler* easy_unlock_handler =
88 chromeos::settings::EasyUnlockSettingsHandler::Create(html_source, 92 chromeos::settings::EasyUnlockSettingsHandler::Create(html_source,
89 profile); 93 profile);
90 if (easy_unlock_handler) 94 if (easy_unlock_handler)
91 AddSettingsPageUIHandler(easy_unlock_handler); 95 AddSettingsPageUIHandler(easy_unlock_handler);
92 #endif 96 #endif
93 97
94 AddSettingsPageUIHandler(AboutHandler::Create(html_source, profile)); 98 AddSettingsPageUIHandler(AboutHandler::Create(html_source, profile));
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 UMA_HISTOGRAM_TIMES("Settings.LoadDocumentTime.MD", 133 UMA_HISTOGRAM_TIMES("Settings.LoadDocumentTime.MD",
130 base::Time::Now() - load_start_time_); 134 base::Time::Now() - load_start_time_);
131 } 135 }
132 136
133 void MdSettingsUI::DocumentOnLoadCompletedInMainFrame() { 137 void MdSettingsUI::DocumentOnLoadCompletedInMainFrame() {
134 UMA_HISTOGRAM_TIMES("Settings.LoadCompletedTime.MD", 138 UMA_HISTOGRAM_TIMES("Settings.LoadCompletedTime.MD",
135 base::Time::Now() - load_start_time_); 139 base::Time::Now() - load_start_time_);
136 } 140 }
137 141
138 } // namespace settings 142 } // namespace settings
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698