[MD Settings] Add feature to enable md-settings by default.

chrome/browser/browser_about_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser_about_handler.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/location.h"
@@ skipping 74 matching lines @@
       host = chrome::kChromeUIHistoryFrameHost;
 #else
       host = chrome::kChromeUIUberHost;
       path = chrome::kChromeUIHistoryHost + url->path();
 #endif
     }
   // Redirect chrome://settings
   } else if (host == chrome::kChromeUISettingsHost) {
     if (::switches::AboutInSettingsEnabled()) {
       host = chrome::kChromeUISettingsFrameHost;
+    } else if (base::FeatureList::IsEnabled(
+                   features::kMaterialDesignSettingsFeature)) {
+      // No rewrite in this case.
     } else {

[Dan Beam, 2016/06/01 20:54:50]

can't this just be:

} else if (!base::FeatureList::IsEnabled(
                features::kMaterialDesignSettingsFeature)) {
  host = chrome::kChromeUIUberHost;
  path = chrome::kChromeUISettingsHost + url->path();
}

[groby-ooo-7-16, 2016/06/02 23:03:53]

I kind of like explicitly calling out the alternatives - so I called it out in
the comments :) (Done)

       host = chrome::kChromeUIUberHost;
       path = chrome::kChromeUISettingsHost + url->path();
     }
   // Redirect chrome://help
   } else if (host == chrome::kChromeUIHelpHost) {
     if (::switches::AboutInSettingsEnabled()) {
       host = chrome::kChromeUISettingsFrameHost;
       if (url->path().empty() || url->path() == "/")
         path = chrome::kChromeUIHelpHost;
+    } else if (base::FeatureList::IsEnabled(
+                   features::kMaterialDesignSettingsFeature)) {

[Dan Beam, 2016/06/01 20:54:50]

same

[groby-ooo-7-16, 2016/06/02 23:03:53]

Done.

     } else {
       host = chrome::kChromeUIUberHost;
       path = chrome::kChromeUIHelpHost + url->path();
     }
   }
 
   GURL::Replacements replacements;
   replacements.SetHostStr(host);
   if (!path.empty())
     replacements.SetPathStr(path);
@@ skipping 13 matching lines @@
         FROM_HERE, base::Bind(&chrome::AttemptRestart));
     return true;
   } else if (base::LowerCaseEqualsASCII(spec, chrome::kChromeUIQuitURL)) {
     base::ThreadTaskRunnerHandle::Get()->PostTask(
         FROM_HERE, base::Bind(&chrome::AttemptExit));
     return true;
   }
 
   return false;
 }