Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 202923003: Fix test serialization path for windows. (Closed)

Created:
6 years, 9 months ago by Michael Achenbach
Modified:
6 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix test serialization path for windows. This work-around takes into account that MSVS doesn't build to "out". BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20261

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M test/cctest/testcfg.py View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL. This fixes the new windows nosnap shared library builder. In a future CL, we ...
6 years, 9 months ago (2014-03-25 14:11:23 UTC) #1
Jakob Kummerow
lgtm
6 years, 9 months ago (2014-03-25 22:10:20 UTC) #2
Michael Achenbach
6 years, 9 months ago (2014-03-26 07:40:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20261 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698