Issue 2029193003: Report HintCode.UNUSED_FIELD for fields which are referenced in constructor field initializers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2029193003: Report HintCode.UNUSED_FIELD for fields which are referenced in constructor field initializers. (Closed)

Created:
4 years, 6 months ago by scheglov

Modified:
4 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Report HintCode.UNUSED_FIELD for fields which are referenced in constructor field initializers. This adds two not false positives in dart2js, and zero to DDC. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f1bc40923a18ed3302ab8c73ff76a50a83e55134

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -0 lines)			Patch
M	pkg/analyzer/lib/src/dart/ast/ast.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/dart/ast/ast_test.dart	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/generated/hint_code_test.dart	View	1 chunk	+24 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

4 years, 6 months ago (2016-06-02 15:00:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f1bc40923a18ed3302ab8c73ff76a50a83e55134 (presubmit successful).