Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Issue 2029073002: [GN] Adding missing source type for extension .appex. (Closed)

Created:
4 years, 6 months ago by justincohen
Modified:
4 years, 6 months ago
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GN] Adding missing source type for extension .appex. Match .appex to wrapper.app-extension BUG= Committed: https://crrev.com/4feb71fc34f559ae3bd16a5a9bbb70c492d1c5ac Cr-Commit-Position: refs/heads/master@{#397247}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/gn/xcode_object.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
justincohen
sdefresne@ ptal brettw@ for OWNERS
4 years, 6 months ago (2016-06-01 16:54:11 UTC) #4
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-01 16:57:42 UTC) #6
sdefresne
lgtm
4 years, 6 months ago (2016-06-01 20:07:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029073002/1
4 years, 6 months ago (2016-06-01 20:08:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 21:18:58 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 21:22:15 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4feb71fc34f559ae3bd16a5a9bbb70c492d1c5ac
Cr-Commit-Position: refs/heads/master@{#397247}

Powered by Google App Engine
This is Rietveld 408576698