Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java

Issue 2029053003: Fix AW tests for Spitzer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Set COPY_REQUIRED flag for WevView video frame and enabled deferred strategy for WebView Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
index ad632bfe40bd1eeb3633f85b7f5d4a518e8bcddf..e0ace3bf6b679b6a9466e7fa596076b34e846c23 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
@@ -12,6 +12,7 @@ import android.view.ViewGroup;
import org.chromium.android_webview.test.util.JavascriptEventObserver;
import org.chromium.android_webview.test.util.VideoSurfaceViewUtils;
import org.chromium.base.test.util.DisableIf;
+import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.parameter.ParameterizedTest;
import org.chromium.content.browser.ContentViewCore;
@@ -213,8 +214,12 @@ public class AwContentsClientFullScreenTest extends AwTestBase {
mTestContainerView);
}
+ /*
@MediumTest
@Feature({"AndroidWebView"})
+ @DisabledTest: crbug.com/597495
+ */
+ @DisabledTest
public void testOnShowCustomViewTransfersHolePunchingSurfaceForVideoInsideDiv()
throws Throwable {
getInstrumentation().runOnMainSync(new Runnable() {
@@ -247,10 +252,13 @@ public class AwContentsClientFullScreenTest extends AwTestBase {
VideoSurfaceViewUtils.waitAndAssertContainsOneVideoHoleSurfaceView(this, customView);
}
+ /*
@MediumTest
@Feature({"AndroidWebView"})
- public void testOnShowCustomViewRemovesHolePunchingSurfaceForVideo()
- throws Throwable {
+ @DisabledTest: crbug.com/597495
+ */
+ @DisabledTest
+ public void testOnShowCustomViewRemovesHolePunchingSurfaceForVideo() throws Throwable {
getInstrumentation().runOnMainSync(new Runnable() {
@Override
public void run() {
@@ -539,11 +547,6 @@ public class AwContentsClientFullScreenTest extends AwTestBase {
loadTestPageAndClickFullscreen(videoTestUrl);
mContentsClient.waitForCustomViewShown();
assertWaitForIsFullscreen();
- if (videoTestUrl.equals(VIDEO_TEST_URL)) {
- // We only create a ContentVideoView (ie. a hardware accelerated surface) when going
- // fullscreen on a video element.
- assertContainsContentVideoView();
- }
}
private void loadTestPageAndClickFullscreen(String videoTestUrl) throws Exception {

Powered by Google App Engine
This is Rietveld 408576698