Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2375)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java

Issue 2029053003: Fix AW tests for Spitzer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reenabled AwContentsClientGetVideoLoadingProgressViewTest Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/ExternalVideoSurfaceContainerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
index dbb78ca01e36dc89d2f91a77eb0780cce4b18c01..dc0c8c5610b1ad2c7cf928d4488bfe166b2b97df 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
@@ -222,9 +222,8 @@ public class AwContentsClientFullScreenTest extends AwTestBase {
@MediumTest
@Feature({"AndroidWebView"})
*/
- @DisabledTest(message = "crbug.com/618749")
- public void testHolePunchingSurfaceNotCreatedForClearVideo()
- throws Throwable {
+ @DisabledTest(message = "crbug.com/597495")
+ public void testHolePunchingSurfaceNotCreatedForClearVideo() throws Throwable {
loadTestPage(VIDEO_TEST_URL);
assertFalse(DOMUtils.isFullscreen(getWebContentsOnUiThread()));
@@ -241,7 +240,7 @@ public class AwContentsClientFullScreenTest extends AwTestBase {
@MediumTest
@Feature({"AndroidWebView"})
*/
- @DisabledTest(message = "crbug.com/618749")
+ @DisabledTest(message = "crbug.com/597495")
public void testOnShowCustomViewTransfersHolePunchingSurfaceForVideoInsideDiv()
throws Throwable {
getInstrumentation().runOnMainSync(new Runnable() {
@@ -278,9 +277,8 @@ public class AwContentsClientFullScreenTest extends AwTestBase {
@MediumTest
@Feature({"AndroidWebView"})
*/
- @DisabledTest(message = "crbug.com/618749")
- public void testOnShowCustomViewRemovesHolePunchingSurfaceForVideo()
- throws Throwable {
+ @DisabledTest(message = "crbug.com/597495")
+ public void testOnShowCustomViewRemovesHolePunchingSurfaceForVideo() throws Throwable {
getInstrumentation().runOnMainSync(new Runnable() {
@Override
public void run() {
@@ -569,11 +567,6 @@ public class AwContentsClientFullScreenTest extends AwTestBase {
loadTestPageAndClickFullscreen(videoTestUrl);
mContentsClient.waitForCustomViewShown();
assertWaitForIsFullscreen();
- if (videoTestUrl.equals(VIDEO_TEST_URL)) {
- // We only create a ContentVideoView (ie. a hardware accelerated surface) when going
- // fullscreen on a video element.
- assertContainsContentVideoView();
- }
}
private void loadTestPageAndClickFullscreen(String videoTestUrl) throws Exception {
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/ExternalVideoSurfaceContainerTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698