Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2121)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java

Issue 2029053003: Fix AW tests for Spitzer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/MultipleVideosTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
index 28642d17e1a7b716b339cb788e80ecd76fa763f7..91ff86e9b5fa6777a6f6e866ce29fd740dac0b27 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
@@ -11,6 +11,7 @@ import android.view.ViewGroup;
import org.chromium.android_webview.test.util.JavascriptEventObserver;
import org.chromium.android_webview.test.util.VideoSurfaceViewUtils;
+import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.FlakyTest;
import org.chromium.base.test.util.parameter.ParameterizedTest;
@@ -214,8 +215,12 @@ public class AwContentsClientFullScreenTest extends AwTestBase {
mTestContainerView);
}
+ /*
@MediumTest
@Feature({"AndroidWebView"})
+ crbug.com/597495
+ */
+ @DisabledTest
public void testOnShowCustomViewTransfersHolePunchingSurfaceForVideoInsideDiv()
throws Throwable {
getInstrumentation().runOnMainSync(new Runnable() {
@@ -248,11 +253,14 @@ public class AwContentsClientFullScreenTest extends AwTestBase {
VideoSurfaceViewUtils.waitAndAssertContainsOneVideoHoleSurfaceView(this, customView);
}
+ /*
@MediumTest
@Feature({"AndroidWebView"})
@FlakyTest
- public void testOnShowCustomViewRemovesHolePunchingSurfaceForVideo()
- throws Throwable {
+ crbug.com/597495
+ */
+ @DisabledTest
+ public void testOnShowCustomViewRemovesHolePunchingSurfaceForVideo() throws Throwable {
getInstrumentation().runOnMainSync(new Runnable() {
@Override
public void run() {
@@ -541,11 +549,6 @@ public class AwContentsClientFullScreenTest extends AwTestBase {
loadTestPageAndClickFullscreen(videoTestUrl);
mContentsClient.waitForCustomViewShown();
assertWaitForIsFullscreen();
- if (videoTestUrl.equals(VIDEO_TEST_URL)) {
- // We only create a ContentVideoView (ie. a hardware accelerated surface) when going
- // fullscreen on a video element.
- assertContainsContentVideoView();
- }
}
private void loadTestPageAndClickFullscreen(String videoTestUrl) throws Exception {
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/MultipleVideosTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698