Change ThrowScriptErrorMessage() to ThrowException().

Change ThrowScriptErrorMessage() to just ThrowException().

Shorter and easier to remember.

Committed: https://pdfium.googlesource.com/pdfium/+/2235b7b52e2cedea9b5d4822de9548994362ca96

[dsinclair, 2016-06-01 14:59:10]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-06-01 14:59:10]

PTAL.

[Tom Sepez, 2016-06-01 18:01:30]

https://codereview.chromium.org/2029043002/diff/1/xfa/fxfa/parser/xfa_object.h
File xfa/fxfa/parser/xfa_object.h (right):

https://codereview.chromium.org/2029043002/diff/1/xfa/fxfa/parser/xfa_object....
xfa/fxfa/parser/xfa_object.h:89: void Throw(int32_t iStringID, ...);
Possibly too easy to confuse with c++'s throw.  Also control flow isn't
modified, eg. execution continues at next line.  Can we come up with a name that
captures these notions as long as we're at it?

/bikeshed.

[dsinclair, 2016-06-01 19:36:10]

Description was changed from

==========
Change ThrowScriptErrorMessage() to just Throw().

Shorter and easier to remember.
==========

to

==========
Change ThrowScriptErrorMessage() to just ThrowException().

Shorter and easier to remember.
==========

[dsinclair, 2016-06-01 19:37:07]

https://codereview.chromium.org/2029043002/diff/1/xfa/fxfa/parser/xfa_object.h
File xfa/fxfa/parser/xfa_object.h (right):

https://codereview.chromium.org/2029043002/diff/1/xfa/fxfa/parser/xfa_object....
xfa/fxfa/parser/xfa_object.h:89: void Throw(int32_t iStringID, ...);
On 2016/06/01 18:01:30, Tom Sepez wrote:
> Possibly too easy to confuse with c++'s throw.  Also control flow isn't
> modified, eg. execution continues at next line.  Can we come up with a name
that
> captures these notions as long as we're at it?
> 
> /bikeshed.
> 

Done.

[Tom Sepez, 2016-06-01 21:35:19]

lgtm

[dsinclair, 2016-06-02 14:29:48]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-06-02 14:29:48]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2029043002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-06-02 14:29:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2029043002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2029043002/40001

[commit-bot: I haz the power, 2016-06-02 14:42:29]

Description was changed from

==========
Change ThrowScriptErrorMessage() to just ThrowException().

Shorter and easier to remember.
==========

to

==========
Change ThrowScriptErrorMessage() to just ThrowException().

Shorter and easier to remember.

Committed:
https://pdfium.googlesource.com/pdfium/+/2235b7b52e2cedea9b5d4822de9548994362...
==========

[commit-bot: I haz the power, 2016-06-02 14:42:30]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/2235b7b52e2cedea9b5d4822de9548994362...