Make deferred loading work with noSuchMethod.

sdk/lib/_internal/compiler/implementation/js_emitter/nsm_emitter.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js.js_emitter;
 
 class NsmEmitter extends CodeEmitterHelper {
   final List<Selector> trivialNsmHandlers = <Selector>[];
 
   /// If this is true then we can generate the noSuchMethod handlers at startup
@@ skipping 263 matching lines @@
         Compiler.NO_SUCH_METHOD, Compiler.NO_SUCH_METHOD_ARG_COUNT);
     var type = 0;
     if (useDiffEncoding) {
       statements.addAll([
         js('var objectClassObject = '
            '        collectedClasses["${namer.getNameOfClass(objectClass)}"],'
            '    shortNames = "$diffEncoding".split(","),'
            '    nameNumber = 0,'
            '    diffEncodedString = shortNames[0],'
            '    calculatedShortNames = [0, 1]'),  // 0, 1 are args for splice.
-        js.if_('objectClassObject instanceof Array',
-               js('objectClassObject = objectClassObject[1]')),
-        js.for_('var i = 0', 'i < diffEncodedString.length', 'i++', [
-          js('var codes = [],'
-             '    diff = 0,'
-             '    digit = diffEncodedString.charCodeAt(i)'),
-          js.if_('digit == ${$PERIOD}', [
-            js('nameNumber = 0'),
-            js('digit = diffEncodedString.charCodeAt(++i)')
+        // If we are loading a deferred library the object class will not be in
+        // the collectedClasses so objectClassObject is undefined, and we skip
+        // setting up the names.
+        js.if_('objectClassObject', [
+          js.if_('objectClassObject instanceof Array',
+                 js('objectClassObject = objectClassObject[1]')),
+          js.for_('var i = 0', 'i < diffEncodedString.length', 'i++', [
+            js('var codes = [],'
+               '    diff = 0,'
+               '    digit = diffEncodedString.charCodeAt(i)'),
+            js.if_('digit == ${$PERIOD}', [
+              js('nameNumber = 0'),
+              js('digit = diffEncodedString.charCodeAt(++i)')
+            ]),
+            js.while_('digit <= ${$Z}', [
+              js('diff *= 26'),
+              js('diff += (digit - ${$A})'),
+              js('digit = diffEncodedString.charCodeAt(++i)')
+            ]),
+            js('diff *= 26'),
+            js('diff += (digit - ${$a})'),
+            js('nameNumber += diff'),
+            js.for_('var remaining = nameNumber',
+                    'remaining > 0',
+                    'remaining = (remaining / 88) | 0', [
+              js('codes.unshift(${$HASH} + remaining % 88)')
+            ]),
+            js('calculatedShortNames.push('
+               '    String.fromCharCode.apply(String, codes))')
           ]),
-          js.while_('digit <= ${$Z}', [
-            js('diff *= 26'),
-            js('diff += (digit - ${$A})'),
-            js('digit = diffEncodedString.charCodeAt(++i)')
-          ]),
-          js('diff *= 26'),
-          js('diff += (digit - ${$a})'),
-          js('nameNumber += diff'),
-          js.for_('var remaining = nameNumber',
-                  'remaining > 0',
-                  'remaining = (remaining / 88) | 0', [
-            js('codes.unshift(${$HASH} + remaining % 88)')
-          ]),
-          js('calculatedShortNames.push('
-             '    String.fromCharCode.apply(String, codes))')
-        ]),
-        js('shortNames.splice.apply(shortNames, calculatedShortNames)')
+          js('shortNames.splice.apply(shortNames, calculatedShortNames)')])
       ]);
     } else {
       // No useDiffEncoding version.
       Iterable<String> longs = trivialNsmHandlers.map((selector) =>
              selector.invocationMirrorMemberName);
       String longNamesConstant = minify ? "" :
           ',longNames = "${longs.join(",")}".split(",")';
       statements.add(
         js('var objectClassObject = '
            '        collectedClasses["${namer.getNameOfClass(objectClass)}"],'
@@ skipping 13 matching lines @@
                          "objectClassObject";
 
     var params = ['name', 'short', 'type'];
     var sliceOffsetParam = '';
     var slice = 'Array.prototype.slice.call';
     if (!sliceOffset.isEmpty) {
       sliceOffsetParam = ', sliceOffset';
       params.add('sliceOffset');
     }
     statements.addAll([
-      js.for_('var j = 0', 'j < shortNames.length', 'j++', [
-        js('var type = 0'),
-        js('var short = shortNames[j]'),
-        js.if_('short[0] == "${namer.getterPrefix[0]}"', js('type = 1')),
-        js.if_('short[0] == "${namer.setterPrefix[0]}"', js('type = 2')),
-        // Generate call to:
-        // createInvocationMirror(String name, internalName, type, arguments,
-        //                        argumentNames)
-        js('$whatToPatch[short] = #(${minify ? "shortNames" : "longNames"}[j], '
-                                    'short, type$sliceOffset)',
-           js.fun(params, [js.return_(js.fun([],
-               [js.return_(js(
-                   'this.$noSuchMethodName('
-                       'this, '
-                       '$createInvocationMirror('
-                           'name, short, type, '
-                           '$slice(arguments$sliceOffsetParam), []))'))]))]))
+      // If we are loading a deferred library the object class will not be in
+      // the collectedClasses so objectClassObject is undefined, and we skip
+      // setting up the names.
+      js.if_('objectClassObject', [
+        js.for_('var j = 0', 'j < shortNames.length', 'j++', [
+          js('var type = 0'),
+          js('var short = shortNames[j]'),
+          js.if_('short[0] == "${namer.getterPrefix[0]}"', js('type = 1')),
+          js.if_('short[0] == "${namer.setterPrefix[0]}"', js('type = 2')),
+          // Generate call to:
+          // createInvocationMirror(String name, internalName, type, arguments,
+          //                        argumentNames)
+          js('$whatToPatch[short] = #(${minify ? "shortNames" : "longNames"}[j], '
+                                      'short, type$sliceOffset)',
+             js.fun(params, [js.return_(js.fun([],
+                 [js.return_(js(
+                     'this.$noSuchMethodName('
+                         'this, '
+                         '$createInvocationMirror('
+                             'name, short, type, '
+                             '$slice(arguments$sliceOffsetParam), []))'))]))]))
+        ])
       ])
     ]);
   }
 }