Introduces "--initializing-formal-access".

Introduces "--initializing-formal-access".

This CL is an adjusted version of CL 2025853002, adding updates to
`InitializingFormalElementZ` to match the updates applied to
`InitializingFormalElementX`, and adding the new option to the
`MessageKind.DUPLICATE_DEFINITION` example.

Description from 2025853002:

This CL adjusts the treatment of initializing formals, such that they
can be used in initializers and in constructor bodies. E.g., `x` can be
used as in `C(this.x) : y = x { var z = x + 2; }`.

It hides the new feature under the option '--initializing-formal-access'
which is used in the test 'initializing_formal_access_test.dart'.

It also adds an `example` test to `MessageKind.DUPLICATE_DEFINITION` to
verify that name clashes among initializing formals and other
parameters are detected (which was previously not the case).

Finally, it fixes a typo in a comment, `InitializingFormalParameter` ->
`InitializingFormalElement`.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/c35caf253efcd497dcdfc0603a56b8bdd34f2d07

[eernst, 2016-06-01 13:24:27]

eernst@google.com changed reviewers:
+ johnniwinther@google.com

[eernst, 2016-06-01 13:24:27]

This CL is a corrected version of the previously landed and reverted CL
2025853002 (updates to 'modelz.dart').

[Johnni Winther, 2016-06-02 07:39:25]

lgtm

[eernst, 2016-06-02 09:10:10]

Description was changed from

==========
Introduces "--initializing-formal-access".

This CL is an adjusted version of CL 2025853002, adding updates to
`InitializingFormalElementZ` to match the updates applied to
`InitializingFormalElementX`, and adding the new option to the
`MessageKind.DUPLICATE_DEFINITION` example.

Description from 2025853002:

This CL adjusts the treatment of initializing formals, such that they
can be used in initializers and in constructor bodies. E.g., `x` can be
used as in `C(this.x) : y = x { var z = x + 2; }`.

It hides the new feature under the option '--initializing-formal-access'
which is used in the test 'initializing_formal_access_test.dart'.

It also adds an `example` test to `MessageKind.DUPLICATE_DEFINITION` to
verify that name clashes among initializing formals and other
parameters are detected (which was previously not the case).

Finally, it fixes a typo in a comment, `InitializingFormalParameter` ->
`InitializingFormalElement`.
==========

to

==========
Introduces "--initializing-formal-access".

This CL is an adjusted version of CL 2025853002, adding updates to
`InitializingFormalElementZ` to match the updates applied to
`InitializingFormalElementX`, and adding the new option to the
`MessageKind.DUPLICATE_DEFINITION` example.

Description from 2025853002:

This CL adjusts the treatment of initializing formals, such that they
can be used in initializers and in constructor bodies. E.g., `x` can be
used as in `C(this.x) : y = x { var z = x + 2; }`.

It hides the new feature under the option '--initializing-formal-access'
which is used in the test 'initializing_formal_access_test.dart'.

It also adds an `example` test to `MessageKind.DUPLICATE_DEFINITION` to
verify that name clashes among initializing formals and other
parameters are detected (which was previously not the case).

Finally, it fixes a typo in a comment, `InitializingFormalParameter` ->
`InitializingFormalElement`.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c35caf253efcd497dcdfc0603a56b8bdd34f2d07
==========

[eernst, 2016-06-02 09:10:12]

Committed patchset #1 (id:1) manually as
c35caf253efcd497dcdfc0603a56b8bdd34f2d07 (presubmit successful).

[floitsch, 2016-06-02 11:59:49]

floitsch@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2016-06-02 11:59:49]

Please add a test that captures the variable and verifies that it isn't the
field.
Also add a test that ensures that the variable is final.

[eernst, 2016-06-02 14:18:48]

On 2016/06/02 11:59:49, floitsch wrote:
> Please add a test that captures the variable and verifies that it isn't the
> field.
> Also add a test that ensures that the variable is final.

Working on a new CL which will do that.