src/x87/code-stubs-x87.cc - Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x87/code-stubs-x87.cc

Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: rebase master Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x87/code-stubs-x87.cc

diff --git a/src/x87/code-stubs-x87.cc b/src/x87/code-stubs-x87.cc

index 326a5d03df0d7f93fadee52c8af3a58d7e4aa68d..66838e2e772c53da63481082061497ff6fbc02a6 100644

--- a/src/x87/code-stubs-x87.cc

+++ b/src/x87/code-stubs-x87.cc

@@ -2435,7 +2435,7 @@ void BinaryOpICWithAllocationSiteStub::Generate(MacroAssembler* masm) {

// Load ecx with the allocation site. We stick an undefined dummy value here

// and replace it with the real allocation site later when we instantiate this

// stub in BinaryOpICWithAllocationSiteStub::GetCodeCopyFromTemplate().

- __ mov(ecx, handle(isolate()->heap()->undefined_value()));

+ __ mov(ecx, isolate()->factory()->undefined_value());

// Make sure that we actually patched the allocation site.

if (FLAG_debug_code) {

« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | test/cctest/heap/test-heap.cc » ('j') | no next file with comments »