src/typing-asm.cc - Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/typing-asm.cc

Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: rebase master Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/typing-asm.cc

diff --git a/src/typing-asm.cc b/src/typing-asm.cc

index d98998520fae35bbc16c305979a6123df1be0cd7..b6eca744310c8e475f66e0b62c4aab5fb8c90fd8 100644

--- a/src/typing-asm.cc

+++ b/src/typing-asm.cc

@@ -603,7 +603,7 @@ void AsmTyper::VisitLiteral(Literal* expr, bool is_return) {

}

} else if (!is_return && value->IsString()) {

RECURSE(IntersectResult(expr, Type::String()));

- } else if (value->IsUndefined()) {

+ } else if (value->IsUndefined(isolate_)) {

RECURSE(IntersectResult(expr, Type::Undefined()));

} else {

FAIL(expr, "illegal literal");

« no previous file with comments | « src/type-info.cc ('k') | src/wasm/wasm-js.cc » ('j') | no next file with comments »