src/snapshot/partial-serializer.cc - Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/snapshot/partial-serializer.cc

Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: rebase master Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/snapshot/partial-serializer.cc

diff --git a/src/snapshot/partial-serializer.cc b/src/snapshot/partial-serializer.cc

index 8aeeed15e9a4f399f39e588499ed43b3294fcefe..fc25191395cb9e363976ba2a8b3ed59edd270057 100644

--- a/src/snapshot/partial-serializer.cc

+++ b/src/snapshot/partial-serializer.cc

@@ -34,7 +34,7 @@ void PartialSerializer::Serialize(Object** o) {

if (context->IsNativeContext()) {

context->set(Context::NEXT_CONTEXT_LINK,

isolate_->heap()->undefined_value());

- DCHECK(!context->global_object()->IsUndefined());

+ DCHECK(!context->global_object()->IsUndefined(context->GetIsolate()));

}

VisitPointer(o);

« no previous file with comments | « src/s390/code-stubs-s390.cc ('k') | src/snapshot/serializer.cc » ('j') | no next file with comments »