Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: src/runtime/runtime-array.cc

Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase master Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/property-descriptor.cc ('k') | src/runtime/runtime-classes.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime/runtime-array.cc
diff --git a/src/runtime/runtime-array.cc b/src/runtime/runtime-array.cc
index f994a14ade541157f710105961c952ebfcb4d240..6484e4d2957be630a2cda0f27789027e7fe88a47 100644
--- a/src/runtime/runtime-array.cc
+++ b/src/runtime/runtime-array.cc
@@ -363,8 +363,7 @@ RUNTIME_FUNCTION(Runtime_ArrayConstructor) {
#endif
Handle<AllocationSite> site;
- if (!type_info.is_null() &&
- *type_info != isolate->heap()->undefined_value()) {
+ if (!type_info.is_null() && !type_info->IsUndefined(isolate)) {
site = Handle<AllocationSite>::cast(type_info);
DCHECK(!site->SitePointsToLiteral());
}
@@ -399,8 +398,8 @@ RUNTIME_FUNCTION(Runtime_ArraySingleArgumentConstructor) {
CONVERT_SMI_ARG_CHECKED(argument_count, 2);
CONVERT_ARG_HANDLE_CHECKED(Object, raw_site, 3);
Handle<AllocationSite> casted_site =
- raw_site->IsUndefined() ? Handle<AllocationSite>::null()
- : Handle<AllocationSite>::cast(raw_site);
+ raw_site->IsUndefined(isolate) ? Handle<AllocationSite>::null()
+ : Handle<AllocationSite>::cast(raw_site);
Arguments constructor_args(argument_count, argument_base);
return ArrayConstructorCommon(isolate, constructor, constructor, casted_site,
&constructor_args);
« no previous file with comments | « src/property-descriptor.cc ('k') | src/runtime/runtime-classes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698