src/ic/handler-compiler.cc - Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/handler-compiler.cc

Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: rebase master Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/handler-compiler.cc

diff --git a/src/ic/handler-compiler.cc b/src/ic/handler-compiler.cc

index 2c8c0925aa37cd5d83d73b8869d8fb74310d1af4..944aecc9254c3fbe6f00fede2379ca2e82436405 100644

--- a/src/ic/handler-compiler.cc

+++ b/src/ic/handler-compiler.cc

@@ -593,7 +593,8 @@ void ElementHandlerCompiler::CompileElementHandlers(

*receiver_map == isolate()->get_initial_js_array_map(elements_kind));

if (receiver_map->has_indexed_interceptor() &&

- !receiver_map->GetIndexedInterceptor()->getter()->IsUndefined() &&

+ !receiver_map->GetIndexedInterceptor()->getter()->IsUndefined(

+ isolate()) &&

!receiver_map->GetIndexedInterceptor()->non_masking()) {

cached_stub = LoadIndexedInterceptorStub(isolate()).GetCode();

} else if (IsSloppyArgumentsElements(elements_kind)) {

« no previous file with comments | « src/ic/call-optimization.cc ('k') | src/ic/ia32/handler-compiler-ia32.cc » ('j') | no next file with comments »