src/full-codegen/mips/full-codegen-mips.cc - Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: rebase master Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/mips/full-codegen-mips.cc

diff --git a/src/full-codegen/mips/full-codegen-mips.cc b/src/full-codegen/mips/full-codegen-mips.cc

index 7312e423d1014e37c9bce96959a60696d808345f..7353030f4ad730459a817b0e9bb54af2bd95707f 100644

--- a/src/full-codegen/mips/full-codegen-mips.cc

+++ b/src/full-codegen/mips/full-codegen-mips.cc

@@ -531,8 +531,9 @@ void FullCodeGenerator::TestContext::Plug(Handle<Object> lit) const {

true,

true_label_,

false_label_);

- DCHECK(lit->IsNull() || lit->IsUndefined() || !lit->IsUndetectable());

- if (lit->IsUndefined() || lit->IsNull() || lit->IsFalse()) {

+ DCHECK(lit->IsNull() || lit->IsUndefined(isolate()) ||

+ !lit->IsUndetectable());

+ if (lit->IsUndefined(isolate()) || lit->IsNull() || lit->IsFalse()) {

if (false_label_ != fall_through_) __ Branch(false_label_);

} else if (lit->IsTrue() || lit->IsJSObject()) {

if (true_label_ != fall_through_) __ Branch(true_label_);