src/full-codegen/full-codegen.cc - Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/full-codegen.cc

Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: rebase master Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/full-codegen.cc

diff --git a/src/full-codegen/full-codegen.cc b/src/full-codegen/full-codegen.cc

index a6ba01d6b7dc6b322d8ba6741ec6b7822587dc51..3d352610589f430bc216663758dcf76cd630092c 100644

--- a/src/full-codegen/full-codegen.cc

+++ b/src/full-codegen/full-codegen.cc

@@ -34,7 +34,8 @@ bool FullCodeGenerator::MakeCode(CompilationInfo* info) {

TRACE_EVENT0("v8", "V8.CompileFullCode");

Handle<Script> script = info->script();

- if (!script->IsUndefined() && !script->source()->IsUndefined()) {

+ if (!script->IsUndefined(isolate) &&

+ !script->source()->IsUndefined(isolate)) {

int len = String::cast(script->source())->length();

isolate->counters()->total_full_codegen_source_size()->Increment(len);

}