src/debug/debug-evaluate.cc - Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/debug-evaluate.cc

Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: rebase master Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/debug/debug-evaluate.cc

diff --git a/src/debug/debug-evaluate.cc b/src/debug/debug-evaluate.cc

index d5ebaa560be1d2180a59a275d3c1bbbcaaeed2c0..62b7a2b4269bf79104633d0e0a552c8ac4f98bc7 100644

--- a/src/debug/debug-evaluate.cc

+++ b/src/debug/debug-evaluate.cc

@@ -250,7 +250,7 @@ void DebugEvaluate::ContextBuilder::MaterializeReceiver(

// referenced by the current function, so it can be correctly resolved.

return;

} else if (local_function->shared()->scope_info()->HasReceiver() &&

- !frame_->receiver()->IsTheHole()) {

+ !frame_->receiver()->IsTheHole(isolate_)) {

recv = handle(frame_->receiver(), isolate_);

}

JSObject::SetOwnPropertyIgnoreAttributes(target, name, recv, NONE).Check();

« no previous file with comments | « src/debug/debug.cc ('k') | src/debug/debug-frames.cc » ('j') | no next file with comments »